Bug 308428 - Possible problem to get corrections with surrogate characters
Summary: Possible problem to get corrections with surrogate characters
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.6   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.6 M7   Edit
Assignee: Olivier Thomann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-07 22:17 EDT by Olivier Thomann CLA
Modified: 2010-04-27 04:18 EDT (History)
1 user (show)

See Also:

Attachments
Proposed fix + regression test (5.67 KB, patch)
2010-04-07 22:31 EDT, Olivier Thomann CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Thomann CLA 2010-04-07 22:17:04 EDT 
The CorrectionEngine is also using a scanner without using the proper options.
So it is possible that the corrections are not right when surrogate characters are used.
Comment 1 Olivier Thomann CLA 2010-04-07 22:31:46 EDT 
Created attachment 164162 [details]
Proposed fix + regression test
Comment 2 Olivier Thomann CLA 2010-04-08 14:00:03 EDT 
Released for 3.6M7.
Added regression test in:
org.eclipse.jdt.core.tests.model.CodeCorrectionTests#testCorrectLocalVariable2
Comment 3 Jay Arthanareeswaran CLA 2010-04-27 04:18:50 EDT 
Verified for 3.6M7 using build I20100424-2000.

An observation, though:
Though the marker view shows the problem, the content assist doesn't offer any completions. I suppose it should be a different bug?