Bug 308356 - codeSelect(..) doesn't work for local variable with surrogate in name
Summary: codeSelect(..) doesn't work for local variable with surrogate in name
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.6   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.6 M7   Edit
Assignee: Olivier Thomann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 308147
  Show dependency tree
 
Reported: 2010-04-07 12:06 EDT by Markus Keller CLA
Modified: 2010-04-27 10:15 EDT (History)
2 users (show)

See Also:

Attachments
Proposed fix (1.25 KB, patch)
2010-04-07 12:31 EDT, Olivier Thomann CLA 		no flags Details | Diff
Same patch with a regression test (3.08 KB, patch)
2010-04-07 13:21 EDT, Olivier Thomann CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2010-04-07 12:06:18 EDT 
HEAD

This is the JDT Core part of bug 308147. I've also tried it with the JavaElement view, and there, I just pass in the selection without any region processing.
Comment 1 Olivier Thomann CLA 2010-04-07 12:31:06 EDT 
Created attachment 164089 [details]
Proposed fix

The selection scanner was not initialized using the project settings. The project needs to be at least in compliance 1.5 to be able to properly read surrogate characters.
Comment 2 Olivier Thomann CLA 2010-04-07 12:31:39 EDT 
With this fix, Java Element view works fine, but the hover is still broken.
Comment 3 Olivier Thomann CLA 2010-04-07 13:21:20 EDT 
Created attachment 164100 [details]
Same patch with a regression test
Comment 4 Olivier Thomann CLA 2010-04-07 13:22:01 EDT 
Released for 3.6M7.
Added regression test:
org.eclipse.jdt.core.tests.model.ResolveTests_1_5#test0124
Comment 5 Jay Arthanareeswaran CLA 2010-04-27 10:15:39 EDT 
Verified for 3.6M7 using build I20100424-2000.