Community
Participate
Working Groups
When presented with a FilteredTree of available projects as the final step in importing a Git repository, checking and unchecking individual projects only works with the mouse. The TreeViewer supports using the keyboard (by navigating with the arrow keys and toggling with the spacebar), but changes made in this fashion are not propagated to the checkedItems field of the GitProjectsImportPage class. (For mouse interactions, a mouse listener is assigned to projectsList, the tree viewer, to manage the checkedItems field in response to selections being made.) To me, it seems that the real problem here is the existence of the checkedItems field in the class for the wizard page. This was introduced a month ago, when Wim Jongman changed what had been a CheckboxTable into a FilteredTree (commit 589c30c2e9eb14550cc6063d2a801d2cc9b8bfb5). Continuously keeping track of which fields are checked should be the responsibility of the UI widget, not the wizard.
Created attachment 163986 [details] First commit
Created attachment 163987 [details] Second commit
Created attachment 163988 [details] Third and final commit In the future, would git format-patch origin/master --stdout > patchname be fine?
(In reply to comment #3) > Created an attachment (id=163988) [details] > Third and final commit > > In the future, would git format-patch origin/master --stdout > patchname be > fine? Hi Ryan, I ran into the same problems when using that class in some other environment and was about to do the same changes, so your patch comes in at exactly the same moment. The official way would be to use the Gerrit code review server (see Egit Contributor guide at http://www.eclipse.org/egit/ -> Developers -> Egit Contributors Guide (or directly http://wiki.eclipse.org/EGit/Contributor_Guide). In order to speed up things a bit, however, I'll integrate this patch manually and upload it to Gerrit.
Code review started on Gerrit: http://egit.eclipse.org/r/525
I've created an account on Gerrit (username rschmitt), it looks like it'll be a lot easier than conventional patches now that it's been set up.
(In reply to comment #6) > I've created an account on Gerrit (username rschmitt), it looks like it'll be a > lot easier than conventional patches now that it's been set up. Hi Ryan, great. Please do not hesistate to check-in your change into Gerrit if you feel like it (but note that I have done some minor adjustments, too which you might want to include). I'll be glad to review your change and abondon mine (making sure you get the credits...). Best regards, Mathias
I'm trying to push it, but I keep getting authentication failures: $ git push ssh://rschmitt@egit.eclipse.org:29418/egit.git HEAD:refs/for/master Enter passphrase for key '/c/Users/GSJ/.ssh/id_rsa': Counting objects: 44, done. Delta compression using up to 4 threads. Compressing objects: 100% (22/22), done. Writing objects: 100% (34/34), 4.38 KiB, done. Total 34 (delta 18), reused 0 (delta 0) To ssh://rschmitt@egit.eclipse.org:29418/egit.git ! [remote rejected] HEAD -> refs/for/master (you are not author ryan.schmitt@boeing.com) error: failed to push some refs to 'ssh://rschmitt@egit.eclipse.org:29418/egit.git' I know I have the passphrase right--is there something wrong with the arguments to git?
New change on gerrit: http://egit.eclipse.org/r/531
MERGED. Thanks!
