Bug 308070 - pde.exportPlugins ant task doesn't support cycles
Summary: pde.exportPlugins ant task doesn't support cycles
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.6   Edit
Hardware: All All
: P3 enhancement with 1 vote (vote)
Target Milestone: 3.7 M6   Edit
Assignee: Curtis Windatt CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2010-04-05 07:28 EDT by ekkehard gentz CLA
Modified: 2011-03-08 06:33 EST (History)
4 users (show)

See Also:

Attachments
patch to add support to pde export ant tasks (3.06 KB, patch)
2010-07-12 17:30 EDT, Cole Markham CLA 		no flags Details | Diff
patch to add support to pde export ant tasks, change to Boolean.parseBoolean (3.48 KB, patch)
2010-07-12 17:31 EDT, Cole Markham CLA 		curtis.windatt.public: iplog+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description ekkehard gentz CLA 2010-04-05 07:28:10 EDT 
it seems that the ant task pde.exportPlugins doesn't support

allowForBinaryCyclesInTargetPlatform

as from PDE --> Export deployable Fragments and Plugins

would be really great if this property could be added

thx

ekke
Comment 1 Darin Wright CLA 2010-04-05 17:31:26 EDT 
Moving to UI. This task is provided by pde.core rather than build.
Comment 2 Cole Markham CLA 2010-07-12 17:30:55 EDT 
Created attachment 174101 [details]
patch to add support to pde export ant tasks

I originally posted this patch to Bug 208011. Now that Helios is out and I'm having to re-patch my eclipse I'm wishing I had pushed to get it in the release. Is this something that could go in the service release, or do we have to wait until Indigo?

Regarding Andrew's comment on Bug 208011, the "true".equals(allowBinaryCycles) was copied from elsewhere in the file. I agree that it should use Boolean.parseBoolean. I will update the patch to fix all such usages in the file.
Comment 3 Cole Markham CLA 2010-07-12 17:31:50 EDT 
Created attachment 174103 [details]
patch to add support to pde export ant tasks, change to Boolean.parseBoolean
Comment 4 Johannes Michler CLA 2010-07-13 03:34:04 EDT 
If someone can provide me some hints how I can apply this patch to test it I could do so and thereby verify if this fixes the problem :-)
Comment 5 Darin Wright CLA 2010-07-13 09:14:22 EDT 
This is an enhancement, so it will be targeted for 3.7.
Comment 6 Curtis Windatt CLA 2011-01-31 12:32:41 EST 
Time is very limited, but we will try to look at this for M6.
Comment 7 ekkehard gentz CLA 2011-01-31 15:57:52 EST 
(In reply to comment #6)
> Time is very limited, but we will try to look at this for M6.

would be really great 

ekke
Comment 8 Curtis Windatt CLA 2011-02-28 12:51:10 EST 
Fixed in HEAD.  Note that we cannot use Boolean.parseBoolean in PDE code because we are 1.4 compliant and it is a 1.5 method.
Comment 9 Ankur Sharma CLA 2011-03-08 06:33:12 EST 
Verified in I20110307-1300