Bug 30794 - Minor API changes to support weaving classloader implementation
Summary: Minor API changes to support weaving classloader implementation
Status: RESOLVED FIXED
Alias: None
Product: AspectJ
Classification: Tools
Component: Compiler (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 2000
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Jim Hugunin CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-02-03 02:05 EST by Martin Lippert CLA
Modified: 2012-04-03 15:46 EDT (History)
1 user (show)

See Also:

Attachments
patch file for weaver project (5.90 KB, patch)
2003-02-03 02:22 EST, Martin Lippert CLA 		aclement: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Lippert CLA 2003-02-03 02:05:00 EST 
I've implemented a classloader which does the weaving at the bytecode level at
class loading time. Therefore I used the weaving functionality implemented in
the weaver project of AspectJ. To implement the classloader I made some minor
API changes (mostly setting a method from private or package to public) and
added a few methods. I would be great if the changes could be integrated into
the head AspectJ project.

One method I added to BcelWeaver is still non-optimal. The new method
"weaveWithoutDump" contains a lot of duplicated code from the "weave" method
(with the same parameters). I will refactor this in the near future.

Thanks!!!
-Martin
Comment 1 Martin Lippert CLA 2003-02-03 02:22:24 EST 
Created attachment 3264 [details]
patch file for weaver project
Comment 2 Jim Hugunin CLA 2003-02-13 21:01:05 EST 
applied patch with no issues.  Made some internal modifications to avoid 
duplicating code in weave method, but left the public weaveWithoutDump method 
in place at least for now.