Bug 307383 - Multiple selection at org.eclipse.gef.ui.parts.TreeViewer using Shift key doesn't work correctly.
Summary: Multiple selection at org.eclipse.gef.ui.parts.TreeViewer using Shift key doe...
Status: NEW
Alias: None
Product: GEF
Classification: Tools
Component: GEF-Legacy GEF (MVC) (show other bugs)
Version: 3.5.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: gef-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-29 09:02 EDT by Martin Slama CLA
Modified: 2010-03-31 07:35 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Slama CLA 2010-03-29 09:02:26 EDT
Build Identifier: M20100211-1343

Multiple selection using the shift key isn't possible at some cases - If the tree contains both modifiable and non-modifiable nodes. There is private boolean ignore; flag at org.eclipse.gef.ui.parts.TreeViewer class which determines whether the selection should be done or not. When you try to do multiple selection with the help of the shift key at modifiable nodes of the tree the method private void showSelectionInTree() is called two times. First time the private boolean ignore flag is true and second time is false. But first time should be false and second time should be true. This causes the shift key has similar behaviour like ctrl key.

Reproducible: Always

Steps to Reproduce:
1. Create some Eclipse plugin which uses Outline.
2. Create some content of the Outline with the help of org.eclipse.gef.ui.parts.TreeViewer class (nodes are non-modifiable and leafs are modifiable). Set edit domain for the TreeViewer.
3. Run the plugin and try to do multiple selection from leaf to another leaf with the help of the shift key. Shift key works in the way of the ctrl key (but it works well from node to node because the nodes are non-modifiable).
Comment 1 Remy Suen CLA 2010-03-31 07:09:41 EDT
Is this an issue with regular tree viewers (like 'Outline' or 'Package Explorer') or is this just an issue with GEF?
Comment 2 Martin Slama CLA 2010-03-31 07:33:09 EDT
(In reply to comment #1)
> Is this an issue with regular tree viewers (like 'Outline' or 'Package
> Explorer') or is this just an issue with GEF?

It's probably issue with GEF. Problem occurs if the outline is linked with MultiPageEditorPart and if EditDomain is set.
Comment 3 Remy Suen CLA 2010-03-31 07:35:21 EDT
(In reply to comment #2)
> It's probably issue with GEF.

Off this bug goes to GEF then. Thank you for the follow-up, Martin.