Bug 307232 - generics related refactoring efforts in 1.6.9
Summary: generics related refactoring efforts in 1.6.9
Status: RESOLVED FIXED
Alias: None
Product: AspectJ
Classification: Tools
Component: Compiler (show other bugs)
Version: DEVELOPMENT   Edit
Hardware: PC Windows 7
: P3 enhancement (vote)
Target Milestone: 1.6.9M2   Edit
Assignee: aspectj inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-26 16:23 EDT by Andrew Clement CLA
Modified: 2010-05-13 13:48 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Clement CLA 2010-03-26 16:23:58 EDT
for some of the generics related bugs, we shouldn't just 'patch things up' anymore.  It is time to do a proper refactoring and sort out some of the types and their relationships.  I'm currently thinking

- rename BoundedReferenceType to WildcardReferenceType - to make it more apparent that is used for '?' references

- break the subtype relationship from TypeVariableReferenceType to BoundedReferenceType - don't like it

- make the bounds requesting methods on TypeVariableReferenceType all simply defer to the typevariable itself, rather than duplicating that state in the TVRT.

- have a single representation of '?' (the unbounded wildcard) in a world, shared.
Comment 1 Andrew Clement CLA 2010-04-05 15:40:16 EDT
made the changes discussed in previous comment.  Only adjustment was, instead of:

- make the bounds requesting methods on TypeVariableReferenceType all simply
defer to the typevariable itself, rather than duplicating that state in the
TVRT.

we expect callers to obtain the typevariable and ask it.
Comment 2 Andrew Clement CLA 2010-04-28 23:56:29 EDT
done what i planned here for now