Community
Participate
Working Groups
Version: 3.6.0 Build id: I20100312-1448 When I open the Plug-in Manifest Editor for a plugin.xml file, I get two menu entries for 'Quick Fix' under the top level menu 'Edit'. For both menu entries the Plug-in Menu Spy reports the following: The active action definition identifier: org.eclipse.jdt.ui.edit.text.java.correction.assist.proposals The active contribution item class: RetargetTextEditorAction The contributing plug-in: org.eclipse.ui.workbench.texteditor (3.6.0.v20100308-1800)
Reproduced. Would be helpful to get a fix from the community.
*** Bug 327682 has been marked as a duplicate of this bug. ***
Created attachment 180784 [details] Fix (In reply to comment #1) > Reproduced. Would be helpful to get a fix from the community. Here you go! ;-)
The patch removes the action from the other editors. I have no idea why the editors separates content assist and correction assist. In any case, the simplest way to fix this is to remove one of the 'support' methods that were turning on both actions (vs other editors that only turn on one or the other). I've fixed this in HEAD in ManifestEditorContributor.
(In reply to comment #4) > The patch removes the action from the other editors. Which ones? The patch is not good yet, as there are still two groups (Content Assist alone in its own group) and in my opinion my fix is at the location. If there are issues, then they need to be correctly fixed.
(In reply to comment #5) > (In reply to comment #4) > > The patch removes the action from the other editors. > Which ones? > > The patch is not good yet, as there are still two groups (Content Assist alone > in its own group) and in my opinion my fix is at the location. If there are > issues, then they need to be correctly fixed. I did not commit the patch, I fixed it in HEAD by making a change in ManifestEditorContributor. Going back through the code, the build properties editor used the supportCorrectionAssist method, the DS editor used the supportContentAssist method, the manifest editor used both. The patch would have broken the build.properties editor. The fix in HEAD is good and will not have any side effects. Closing.
> I did not commit the patch, I fixed it in HEAD by making a change in > ManifestEditorContributor. Yes, I know. My wording was wrong. I wanted to say that your fix in HEAD is wrong for the following reasons: 1. Your fix still leaves two entries for the build properties editor (N20101018-2000). 2. Content Assist is still in its own group which is wrong. 3. I don't see what part of the build.properties editor my patch would break. 4. Your fix is at the wrong location while mine is where it should be.
I didn't see your duplicate issue with my fix when self-hosting or in N20101019, but your fix is working for me and also includes moving the content assist action to the correct group. I have reverted my fix and committed yours.
> I didn't see your duplicate issue with my fix when self-hosting or in > N20101019, Can't reproduce it now either. > but your fix is working for me and also includes moving the content > assist action to the correct group. I have reverted my fix and committed > yours. Thanks! Verified in I20101026-1800.
