Bug 307131 - URLImageEditPart throws IllegalArgumentException when trying to generate an image from URL
Summary: URLImageEditPart throws IllegalArgumentException when trying to generate an i...
Status: RESOLVED FIXED
Alias: None
Product: GMF-Runtime
Classification: Modeling
Component: General (show other bugs)
Version: 2.3   Edit
Hardware: PC Windows XP
: P3 normal
Target Milestone: 2.3   Edit
Assignee: Alex Boyko CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-25 15:55 EDT by Syed Atif CLA
Modified: 2010-07-19 12:29 EDT (History)
1 user (show)

See Also:

Attachments
Fix Patch (1.36 KB, patch)
2010-03-25 16:00 EDT, Syed Atif CLA 		no flags Details | Diff
Fix Patch (1.36 KB, patch)
2010-03-25 16:04 EDT, Syed Atif CLA 		ahunter.eclipse: iplog+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Syed Atif CLA 2010-03-25 15:55:32 EDT 
Build Identifier: GMF Feature 1.4.0.v20100223-2359

There was a recent change (bug 303688) that allowed more flexibility when reading in URLs for generating images by using EMF URIs. In the regenerateImageFromSource() method, if the supplied URL is malformed, EMF's URI.createURI(..) throws an IllegalArgumentException, which is not caught and handled properly in this method.

Reproducible: Always
Comment 1 Syed Atif CLA 2010-03-25 16:00:29 EDT 
Created attachment 163030 [details]
Fix Patch

Try catch guard fixes the problem
Comment 2 Syed Atif CLA 2010-03-25 16:04:18 EDT 
Created attachment 163031 [details]
Fix Patch

Try catch guard code fixes the problem.
Comment 3 Syed Atif CLA 2010-03-25 16:07:35 EDT 
The two patches are the same ... bugzilla went bonkers.
Comment 4 Alex Boyko CLA 2010-03-25 16:07:55 EDT 
Two identical patches? One for me one for you I guess :-)
Comment 5 Alex Boyko CLA 2010-03-25 18:24:32 EDT 
Committed Syed's patch for 2.3 M7
Comment 6 Eclipse Webmaster CLA 2010-07-16 23:38:22 EDT 
[target cleanup] 2.3 M7 was the original target milestone for this
bug
Comment 7 Eclipse Webmaster CLA 2010-07-19 12:29:20 EDT 
[GMF Restructure] Bug 319140 : product GMF and component
Runtime Diagram was the original product and component for this bug