Bug 306862 - [api] Remove IExpressionFactory and IExpressionParser Services exposed by org.eclipse.equinox.p2.metadata
Summary: [api] Remove IExpressionFactory and IExpressionParser Services exposed by org...
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: 3.6   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.6 M7   Edit
Assignee: Thomas Hallgren CLA
QA Contact:
URL:
Whiteboard:
Keywords: api
Depends on:
Blocks: 305588
  Show dependency tree
 
Reported: 2010-03-23 14:45 EDT by Jason Barkanic CLA
Modified: 2010-04-09 07:00 EDT (History)
4 users (show)

See Also:
tjwatson: pmc_approved+
thomas: pmc_approved? (jeffmcaffer)
pascal: review+

Attachments
Patch that removes the expression parser and factory services (11.01 KB, patch)
2010-03-24 12:52 EDT, Thomas Hallgren CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jason Barkanic CLA 2010-03-23 14:45:03 EDT 
Build Identifier: 3.6

IExpressionFactory and IExpressionParser service implementations published in org.eclipse.equinox.p2.metadata are no longer necessary.  Should they remain exposed, or be removed?

http://dev.eclipse.org/mhonarc/lists/p2-dev/msg02897.html
https://bugs.eclipse.org/bugs/show_bug.cgi?id=306217


Reproducible: Always
Comment 1 Thomas Hallgren CLA 2010-03-24 12:52:24 EDT 
Created attachment 162879 [details]
Patch that removes the expression parser and factory services
Comment 2 Pascal Rapicault CLA 2010-03-25 01:59:07 EDT 
I agree that they should be removed. The fewer API we have the better we are.
Comment 3 Ian Bull CLA 2010-03-29 17:42:21 EDT 
Removing them will also fix bug 305588
Comment 4 Thomas Hallgren CLA 2010-04-02 02:19:18 EDT 
Thomas or Jeff, can you please review this patch and pass a verdict?
Comment 5 Thomas Hallgren CLA 2010-04-02 02:23:53 EDT 
The change is described in the p2-dev posting "API change! QueryUtil changes and their impact on testability" http://dev.eclipse.org/mhonarc/lists/p2-dev/msg02901.html. So far it has had no comments.
Comment 6 Thomas Hallgren CLA 2010-04-07 10:50:45 EDT 
On the Monday call we agreed that keeping the serivces should be considered a bug since a lot of code would break if someone attempted to register an alternative implementation.

Can this be approved now please?
Comment 7 Thomas Watson CLA 2010-04-08 15:56:01 EDT 
Yes, we agreed to do this at Monday's p2 call.

+1
Comment 8 Thomas Hallgren CLA 2010-04-09 07:00:28 EDT 
Committed.