Bug 306519 - JavaCore#getReferencedClasspathEntries(IClasspathEntry, IJavaProject) should allow null project
Summary: JavaCore#getReferencedClasspathEntries(IClasspathEntry, IJavaProject) should ...
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.6   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: 3.6 M7   Edit
Assignee: Jay Arthanareeswaran CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-19 09:15 EDT by Markus Keller CLA
Modified: 2010-04-26 13:42 EDT (History)
2 users (show)

See Also:

Attachments
Patch with updated API doc and test (4.32 KB, patch)
2010-04-09 05:26 EDT, Jay Arthanareeswaran CLA 		no flags Details | Diff
Path with updated doc (4.28 KB, patch)
2010-04-09 06:12 EDT, Jay Arthanareeswaran CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2010-03-19 09:15:19 EDT 
HEAD

JavaCore#getReferencedClasspathEntries(IClasspathEntry, IJavaProject) should allow the project to be null. This would make the API work also in cases where the client only wants to find referenced entries, but does not have a context at hand.
Comment 1 Jay Arthanareeswaran CLA 2010-04-09 05:26:52 EDT 
Created attachment 164347 [details]
Patch with updated API doc and test

This patch includes some addition to the documentation of the following API - JavaCore#getReferencedClasspathEntries(IClasspathEntry, IJavaProject)

Olivier, with the API documentation changes, can this still be part of 3.6?
Comment 2 Markus Keller CLA 2010-04-09 06:00:51 EDT 
(In reply to comment #1)
This part of the original Javadoc has been lost in the patched version:
"For more details on storing referenced entries"

This change does not affect existing clients, so it's OK for 3.6.
Comment 3 Jay Arthanareeswaran CLA 2010-04-09 06:12:59 EDT 
Created attachment 164349 [details]
Path with updated doc

Oops, somehow missed that while comparing. Attaching the updated patch.
Comment 4 Olivier Thomann CLA 2010-04-09 09:00:54 EDT 
Doc changes are ok as long as the API itself is not changed.
Comment 5 Jay Arthanareeswaran CLA 2010-04-12 06:46:40 EDT 
Released in HEAD for 3.6M7.
Comment 6 Ayushman Jain CLA 2010-04-26 03:09:25 EDT 
Verified for 3.6M7 through code inspection
Comment 7 Jay Arthanareeswaran CLA 2010-04-26 13:42:17 EDT 
Verified.