Bug 305255 - [preferences] Accept jsr14 as a build target
Summary: [preferences] Accept jsr14 as a build target
Status: RESOLVED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.6   Edit
Hardware: PC Linux
: P5 enhancement (vote)
Target Milestone: 3.7 M2   Edit
Assignee: JDT-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-09 17:31 EST by Ian Bull CLA
Modified: 2010-11-29 08:16 EST (History)
6 users (show)

See Also:


Attachments
Screenshot showing the problem (35.19 KB, image/png)
2010-03-09 17:31 EST, Ian Bull CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ian Bull CLA 2010-03-09 17:31:55 EST
Created attachment 161539 [details]
Screenshot showing the problem

In p2 we are currently targeting jsr14, that is, using Java 5 syntax but building down to Java 1.4 bytecode.  The target was set manually in the jdt preferences, but if you open the project properties, you get some strange errors (see attached screenshot).

Can jsr14 be added as a option for generated .class compatibility?
Comment 1 Markus Keller CLA 2010-03-10 05:25:18 EST
jsr14 is not an officially supported target version.
Comment 2 Ian Bull CLA 2010-03-10 12:15:44 EST
(In reply to comment #1)
> jsr14 is not an officially supported target version.

Thanks Markus. I hadn't realized this until Olivier mentioned it on Bug 305259.  Since part of the SDK (p2) is now making use of this target, can we work towards making it a supported target (for Eclipse 3.7)? Or is it more complicated than this?
Comment 3 Pascal Rapicault CLA 2010-03-10 12:47:52 EST
Ian, when we started using this feature in p2, there was a tacit agreement between Olivier and I (and even discussed during the eclipse team meeting) that we would not ask to make that support full fledged because this could require a lot of work and would not be useful to a majority of ppl (like support for Java 7 would).
Comment 4 Ian Bull CLA 2010-03-10 13:04:54 EST
(In reply to comment #3)
> Ian, when we started using this feature in p2, there was a tacit agreement
> between Olivier and I (and even discussed during the eclipse team meeting) that
> we would not ask to make that support full fledged because this could require a
> lot of work and would not be useful to a majority of ppl (like support for Java
> 7 would).

+1, thanks for the clarification, I hadn't realized this.  I'm actually very impressed with how well the down compiling works (other than a few minor annoyances).  I agree that we should not spend time on this (especially if its a lot of work, and it only benefits a few).  If others in the platform start to make use of this, then maybe these requests can be reconsidered.  

I would be happy to close these bugs as WONTFIX, or even Invalid (since I didn't realize that we had this agreement in place).  Sorry for causing any confusion, and thanks for the quick responses.
Comment 5 John Arthorne CLA 2010-03-10 13:23:22 EST
It's ok Ian, I think it's useful to have the problems documented in case we consider it something worth supporting in a future release.
Comment 6 Dani Megert CLA 2010-03-16 12:54:52 EDT
We can keep the bug open but currently there are no plans to invest into jsr14 target.
Comment 7 Markus Keller CLA 2010-09-04 07:02:21 EDT
I've "fixed" comment 0 in the UI (in ComplianceConfigurationBlock.java).

Iff the target is already jsr14, then we also show this in the UI and don't show bad error messages. Otherwise, you still don't see jsr14 (so this target is only passively supported after it has been set manually in the .prefs file).
Comment 8 Olivier Thomann CLA 2010-11-26 14:15:44 EST
If jsr14 is used inside the preference file, then it is shown in the UI.
No further change plan at the core level.

Moving to JDT/UI to be closed as FIXED (comment 7).
Comment 9 Markus Keller CLA 2010-11-29 08:16:34 EST
(In reply to comment #8)
> If jsr14 is used inside the preference file, then it is shown in the UI.
> No further change plan at the core level.
> 
> Moving to JDT/UI to be closed as FIXED (comment 7).

OK, changed the summary from "Support jsr14..." to "Accept jsr14...".