Bug 304786 - Provide additional test cases to verify Map support in CDO
Summary: Provide additional test cases to verify Map support in CDO
Status: ASSIGNED
Alias: None
Product: EMF
Classification: Modeling
Component: cdo.core (show other bugs)
Version: 4.13   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Martin Fluegge CLA
QA Contact: Eike Stepper CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-05 04:45 EST by Martin Fluegge CLA
Modified: 2020-12-11 10:44 EST (History)
1 user (show)

See Also:
stepper: review+


Attachments
test patch V1 (441.16 KB, patch)
2010-03-05 14:25 EST, Martin Fluegge CLA
no flags Details | Diff
Test Patch v2 - ready to be committed (440.08 KB, patch)
2010-03-10 02:49 EST, Eike Stepper CLA
no flags Details | Diff
Test Patch v3 (44.17 KB, patch)
2010-03-14 16:45 EDT, Martin Fluegge CLA
no flags Details | Diff
Patvh v4 - ready to be committed (44.95 KB, patch)
2010-03-15 13:47 EDT, Eike Stepper CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Fluegge CLA 2010-03-05 04:45:31 EST
We need a bunch of test cases to verify the support of different types of Maps.
Comment 1 Stefan Winkler CLA 2010-03-05 07:33:34 EST
More testcases is always a good thing. Thanks, Martin.
As a sidenote: feature-map support could also deal with some more testcases ;)
Comment 2 Martin Fluegge CLA 2010-03-05 14:25:07 EST
Created attachment 161170 [details]
test patch V1

Hi guys, 

I added some new features to the Model2 and wrote some test cases for it. Well concentrating on every key/value pair for any possible combination of maps would result int 64 new map, only for the primitive types. So I just concentrated on the must common combinations (in my opinion). But I wrote the test cases as generic as possible, so we can later add other maps easily. 

The good news is: All maps tests are working fine with CDO. Map supports seems to be quite well implemented ?

@Stefan: featuremap test are already on the agenda ;) I am currently planning a model which even contains bidirectional features map. 

@Eike
 800 ;)
Comment 3 Eike Stepper CLA 2010-03-05 14:26:59 EST
Is it possible to create dynamic models for more combinations on the fly?
Comment 4 Martin Fluegge CLA 2010-03-05 14:57:24 EST
Hmm, could be. But than I must also care for a dynamich Legacy version. I'll try it out.
Comment 5 Eike Stepper CLA 2010-03-06 00:29:43 EST
(In reply to comment #4)
> Hmm, could be. But than I must also care for a dynamich Legacy version. I'll
> try it out.

Not sure I understand. Dynamic modls are always native through DynamicCDFOObjectImpl.
Comment 6 Martin Fluegge CLA 2010-03-06 03:15:43 EST
Now I am confused. ;) 
If I just create an EFactory and EPackage without using CDOUtil.prepareDynamicEPackage() than it will only create DynamicEObject instead of DynamicCDOObjects. Or I am wrong here? If not I meant that that we need both versions (legacy/native) of package and factory. I'll ping you later this day...
Comment 7 Eike Stepper CLA 2010-03-10 02:49:42 EST
Created attachment 161575 [details]
Test Patch v2 - ready to be committed
Comment 8 Martin Fluegge CLA 2010-03-11 15:37:20 EST
Committed to HEAD.

Dynamic tests for additional test coverage coming soon.
Comment 9 Martin Fluegge CLA 2010-03-14 16:45:15 EDT
Created attachment 161988 [details]
Test Patch v3

Hi,

I played a bit with the dynamic stuff and managed to get a quite good test coverage for maps. 

We now have about 480 additional tests for maps running in one dynamical test ;)  (see MapTest,java)


I also managed to create dynamic JUnit tests, so every single dynamic test case is shown in the JUnit UI (see DynamicMapTest.java). Unfortunately I was not able to integrate this test into our nice test framework. This means the test has to be started manually from the ?Run As? context menu. 

Note, that the dynamic version only tests maps with EAttributes for key and value. I will see that I can write additional test for EReferences as key/value combination.

I also need to change the current dynamic implementation to work with legacy because by now every dynamically create object is native. 

Finally I had to tweak the framework a bit to generate dynamic maps in CDO, which was not supported.

The good news in the end: Seems that maps are well supported in CDO ?
Comment 10 Eike Stepper CLA 2010-03-15 13:47:14 EDT
Created attachment 162088 [details]
Patvh v4 - ready to be committed
Comment 11 Martin Fluegge CLA 2010-03-17 05:25:18 EDT
Committed ot HEAD.

Last thing to do is to integrate the DynamicMapTest into our test framework.
Comment 12 Eike Stepper CLA 2010-06-29 04:51:02 EDT
Rebasing all outstanding enhancements requests to version 4.0
Comment 13 Eike Stepper CLA 2011-06-23 03:58:43 EDT
Moving all open enhancement requests to 4.1
Comment 14 Eike Stepper CLA 2012-08-14 22:57:19 EDT
Moving all open issues to 4.2. Open bugs can be ported to 4.1 maintenance after they've been fixed in master.
Comment 15 Eike Stepper CLA 2013-06-27 04:08:17 EDT
Moving all outstanding enhancements to 4.3
Comment 16 Eike Stepper CLA 2014-08-19 09:27:05 EDT
Moving all open enhancement requests to 4.4
Comment 17 Eike Stepper CLA 2014-08-19 09:37:03 EDT
Moving all open enhancement requests to 4.4
Comment 18 Eike Stepper CLA 2015-07-14 02:21:02 EDT
Moving all open bugzillas to 4.5.
Comment 19 Eike Stepper CLA 2016-07-31 01:03:48 EDT
Moving all unaddressed bugzillas to 4.6.
Comment 20 Eike Stepper CLA 2017-12-28 01:09:22 EST
Moving all open bugs to 4.7
Comment 21 Eike Stepper CLA 2019-11-08 02:14:59 EST
Moving all unresolved issues to version 4.8-
Comment 22 Eike Stepper CLA 2019-12-13 12:53:06 EST
Moving all unresolved issues to version 4.9
Comment 23 Eike Stepper CLA 2020-12-11 10:44:10 EST
Moving to 4.13.