Bug 303330 - [reconciler] No diagnosis of dropin problems
Summary: [reconciler] No diagnosis of dropin problems
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: 3.4.2   Edit
Hardware: PC Windows Vista
: P3 enhancement (vote)
Target Milestone: 3.4.2+   Edit
Assignee: P2 Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted
Depends on: 200380 264924
Blocks:
  Show dependency tree
 
Reported: 2010-02-19 10:47 EST by DJ Houghton CLA
Modified: 2010-03-05 18:31 EST (History)
22 users (show)

See Also:

Attachments
patch (11.51 KB, patch)
2010-03-05 18:31 EST, DJ Houghton CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description DJ Houghton CLA 2010-02-19 10:47:53 EST 
Cloned to trace fix release into the 3.4.x stream.

+++ This bug was initially created as a clone of Bug #264924 +++

M5

Unzip eclipse-SDK-3.5M5-win32.zip to ..../eclipse
Unzip mdt-ocl-SDK-1.3.0M5.zip to ..../eclipse/dropins/mdt-ocl-SDK-1.3.0M5

This is a problematic configuration since OCL depends on EMF which is missing.
3.5M5 provides no diagnosis of this problem.

Start eclipse.

No obvious problems. Nothing in Error Log.

Help About plugin details shows org.eclipse.ocl.doc, but not org.eclipse.ocl.
Help About Configuration Details has no (diagnostic) mention of org.eclipse.ocl.
Help Installation Information Installed Software has no mention of org.eclipse.ocl

Where are the nice error markers?
Comment 1 DJ Houghton CLA 2010-02-19 10:49:03 EST 
There is a patch for 34x on bug 264924.
Comment 2 Daniel Le Berre CLA 2010-02-19 10:57:04 EST 
We cannot detect problems occurring in the dropins folder because we consider those dependencies as optional in the solver.

As such, if some plugins cannot be installed together, the solver will just ignore some of them (that's the specificity of optional dependencies).
Comment 3 DJ Houghton CLA 2010-02-19 11:18:13 EST 
Daniel: Agreed. This is really just a request for optional debug info that can print out a list of what was and wasn't installed, and then support teams can enable this tracing and hopefully figure the reasons behind it.
Comment 4 Daniel Le Berre CLA 2010-02-19 11:31:06 EST 
Maybe one solution would be to turn optional dependencies into regular dependencies and to ask the solver for an explanation?
Comment 5 John Arthorne CLA 2010-02-19 11:43:49 EST 
(In reply to comment #2)
> We cannot detect problems occurring in the dropins folder because we consider
> those dependencies as optional in the solver.

Daniel, we're just talking about having some feedback about the end result of the solver's computation. I.e., "you requested to install x, y, and z, but we have only installed "x and y". Currently there is no feedback about what plugins got installed/uninstalled after changes are made to the dropins folder on disk. I don't think we want to tackle explanations about *why* it came to that decision here (which is a far more difficult problem).
Comment 6 Daniel Le Berre CLA 2010-02-19 15:36:15 EST 
ok, fine. Nice idea.

One have to be careful: you might have 3 versions of the same IU in the dropins.
Only one is likely to be needed (the latest one for instance).

It should be wise not to log that the older versions are not installed.
Comment 7 DJ Houghton CLA 2010-03-04 10:13:12 EST 
Released to branch.
Comment 8 DJ Houghton CLA 2010-03-05 18:31:19 EST 
Created attachment 161208 [details]
patch

For interested parties, here is the patch which was applied. (might be in reverse but you get the idea)