Bug 303314 - [preferences] Add new options to 'code formatter' to expose constant from bug 282030
Summary: [preferences] Add new options to 'code formatter' to expose constant from bug...
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.6   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.6 M6   Edit
Assignee: Markus Keller CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 282030
Blocks:
  Show dependency tree
 
Reported: 2010-02-19 09:08 EST by Frederic Fusier CLA
Modified: 2010-03-10 09:06 EST (History)
3 users (show)

See Also:

Attachments
Proposed patch (4.08 KB, patch)
2010-02-19 09:11 EST, Frederic Fusier CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Frederic Fusier CLA 2010-02-19 09:08:44 EST 
Once bug 282030 is fixed, the new constant needs to be exposed in the code
formatter preference page.
Comment 1 Frederic Fusier CLA 2010-02-19 09:11:14 EST 
Created attachment 159545 [details]
Proposed patch

This patch adds a new 'Annotations' category in the 'Line Wrapping' tab of the formatter preference page.
Comment 2 Markus Keller CLA 2010-02-23 04:55:14 EST 
Thanks for the patch, released to HEAD.
Comment 3 Deepak Azad CLA 2010-03-09 23:06:46 EST 
Tested with I20100309-0100.

For all 'Wrap all elements, *' options the 'Force split' option has no affect. This behavior is inconsistent with implementation for other categories like Method Declarations. See Bug 303506.
Comment 4 Frederic Fusier CLA 2010-03-10 06:20:41 EST 
(In reply to comment #3)
> Tested with I20100309-0100.
> 
> For all 'Wrap all elements, *' options the 'Force split' option has no affect.
> This behavior is inconsistent with implementation for other categories like
> Method Declarations. See Bug 303506.

It does, but you need to use a larger width, e.g. 256. Then, you'll observe the same behavior than for method declaration...
Comment 5 Deepak Azad CLA 2010-03-10 09:06:51 EST 
Verified with I20100309-0100 for 3.6 M6.

(In reply to comment #4)
> It does, but you need to use a larger width, e.g. 256. Then, you'll observe the
> same behavior than for method declaration...
Yes, you are right. I was not setting a large enough width.