Bug 303269 - [repository] The method signatures on IMetadataRepository should take collections
Summary: [repository] The method signatures on IMetadataRepository should take collect...
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: 3.6   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: 3.6 M6   Edit
Assignee: DJ Houghton CLA
QA Contact:
URL:
Whiteboard:
Keywords: api
Depends on: 303374
Blocks:
  Show dependency tree
 
Reported: 2010-02-18 22:58 EST by Pascal Rapicault CLA
Modified: 2010-02-22 15:11 EST (History)
1 user (show)

See Also:

Attachments
patch (25.88 KB, patch)
2010-02-19 18:44 EST, DJ Houghton CLA 		no flags Details | Diff
patch (25.24 KB, patch)
2010-02-19 20:26 EST, DJ Houghton CLA 		no flags Details | Diff
patch (69.81 KB, patch)
2010-02-22 15:09 EST, DJ Houghton CLA 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pascal Rapicault CLA 2010-02-18 22:58:40 EST 
The method on IMetadataRepository should take collections. The one I have seen at this point are addInstallableUnits and removeInstallableUnits.
Comment 1 DJ Houghton CLA 2010-02-19 18:44:43 EST 
Created attachment 159634 [details]
patch

Work in progress patch. 
- removes the progress monitor from the #remove method
- change method args from Arrays to Collection
- javadoc fixup
Comment 2 DJ Houghton CLA 2010-02-19 20:21:36 EST 
Comment on attachment 159634 [details]
patch

Bad patch... will update.
Comment 3 DJ Houghton CLA 2010-02-19 20:26:42 EST 
Created attachment 159643 [details]
patch
Comment 4 DJ Houghton CLA 2010-02-22 15:09:50 EST 
Created attachment 159840 [details]
patch
Comment 5 DJ Houghton CLA 2010-02-22 15:11:09 EST 
Patch released to HEAD.