Bug 30227 - compilerAdapter jar should not be include in the repo
Summary: compilerAdapter jar should not be include in the repo
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 2.1   Edit
Hardware: PC Windows 2000
: P3 normal (vote)
Target Milestone: 2.1 M5   Edit
Assignee: Olivier Thomann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 30440
Blocks:
  Show dependency tree
 
Reported: 2003-01-25 15:57 EST by Jeff McAffer CLA
Modified: 2003-02-10 12:25 EST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeff McAffer CLA 2003-01-25 15:57:15 EST 
Currently the jdt.core project has the file jdtCompilerAdapter.jar in the root. 
This file is a derived resource and should not be included in the repository.  
Under certain circumstances it can conflict with the build mechanism causing 
its recompilation to be skipped and the source and logs not be shipped 
properly.  Please remove as soon as possible.
Comment 1 Philipe Mulet CLA 2003-01-25 16:48:12 EST 
Well for testing purpose we use it too. The original story was that it was 
overriden anyway.
Comment 2 Jeff McAffer CLA 2003-01-26 21:09:35 EST 
Using it for testing is fine and removing it from the repo should not be a 
barrier.  The jar should be built by an externalToolsBuilder on your project 
when you load the project into your workspace.  For an example of how the other 
teams do this, see org.eclipse.core.resources.  

Not deriving it in this way can lead to inconsistencies when you change code 
that the jar uses but the jar is not recompiled/rebuilt.
Comment 3 Philipe Mulet CLA 2003-01-27 14:58:14 EST 
Olivier - please do the necessary so as to get it recreated on a build action. 
I assume it only gets created if missing (during the build process).
Comment 4 Olivier Thomann CLA 2003-01-28 16:27:17 EST 
I am waiting to get an ant task from platform core that would allow me to set
the derived bit. Right now the script is ready, but the generated file is not
set as derived.
Comment 5 Philipe Mulet CLA 2003-01-30 07:39:45 EST 
adapter removed from our contribution.
Marking as fixed. derived bit is a separate issue which can be resolved 
independently.
Comment 6 David Audel CLA 2003-02-10 12:25:06 EST 
Verified.