Bug 301969 - Module Assembly page entries not editable with keyboard
Summary: Module Assembly page entries not editable with keyboard
Status: NEW
Alias: None
Product: WTP Common Tools
Classification: WebTools
Component: wst.common (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows Vista
: P2 major (vote)
Target Milestone: 4.0   Edit
Assignee: Rob Stryker CLA
QA Contact: Carl Anderson CLA
URL:
Whiteboard:
Keywords: accessibility
Depends on:
Blocks:
 
Reported: 2010-02-05 10:37 EST by Kaloyan Raev CLA
Modified: 2013-03-21 11:15 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kaloyan Raev CLA 2010-02-05 10:37:10 EST
There is a keyboard accessibility issue in the new Module Assembly page. 

As far as I can see an entry in the list could be edited by clicking on the Deploy Path cell with the mouse. Then the cell becomes in edit mode. 

I don't find any other way to edit an entry. If there is no mouse, but just using the keyboard, it is impossible to switch the table cell in edit mode. 

I wonder if the Edit Ear Module Reference... button (which is always disabled) is designed for this purpose. Is it supposed, that when the logic of this button is implemented), it will switch the current selection in the table to edit mode?

I can prepare a patch fixing the issue, if I know more on the initial design of the Module Assembly page.
Comment 1 Carl Anderson CLA 2010-02-11 15:23:40 EST
Assigning to Chuck for initial investigation.
Comment 2 Chuck Bridgham CLA 2010-03-08 10:10:21 EST
Moving this to M7, may need some assistance from Rob.. Possibly a special keystroke to enter edit mode
Comment 3 Rob Stryker CLA 2010-05-13 01:24:29 EDT
Targeting to generic 3.2. If someone can offer me advice on how to do this I can look into it, but until then it's only tentatively planned for 3.2 and if no advice comes will be retargeted to later
Comment 4 Kaloyan Raev CLA 2010-05-14 06:57:17 EDT
The most natural way I see for the moment is to use the Edit button. When the user click the Edit button, the current selection in the table will switch to edit mode (like the user has clicked on the left cell). This would be a good use of the Edit button, which is currently disabled.
Comment 5 Rob Stryker CLA 2010-05-17 02:13:05 EDT
The edit button is *not* currently disabled. it is currently disabled for any reference type which does not have an edit action associated with it. 

For other reference types, such as filesets, or any custom reference type created by adopters, 'edit' will open a wizard (same wizard as add) with the page which claims to be able to edit that reference type. 

Adding such an editor for project / jar / external jar references would be trivial but ultimately pointless because editing a reference from ProjectA to ProjectB would be functionally equivalent to simply removing the ProjectA reference and adding a new ProjectB reference. 

However for any other custom reference implementation with lots of parameters, such as a fileset, this is not the case. For example assuming a fileset has basedir, includes, excludes, flatten, etc as parameters, and you want to change just one (the includes pattern), to delete that reference and add a virtually identical one with a slightly changed includes pattern is overburdening to the user. Hence, the edit button.

So the edit button cannot be used to enable modifying the deploy path and a different way must be found.
Comment 6 Rob Stryker CLA 2010-05-28 11:11:24 EDT
I cannot think of a good way to implement this now, being as the 'edit' button has its own other uses. Without some more suggestions as to a convenient and clean way to allow the user to edit the field, I'm left with pushing this forward