Bug 301658 - [query] IUQuery overrides getID and changes the semantics of the method
Summary: [query] IUQuery overrides getID and changes the semantics of the method
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 3.6 M6   Edit
Assignee: Ian Bull CLA
QA Contact:
URL:
Whiteboard:
Keywords: api
Depends on:
Blocks:
 
Reported: 2010-02-02 23:18 EST by Ian Bull CLA
Modified: 2010-02-03 13:07 EST (History)
2 users (show)

See Also:


Attachments
patch (16.89 KB, patch)
2010-02-03 12:53 EST, Ian Bull CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ian Bull CLA 2010-02-02 23:18:01 EST
There is a method on IQuery called getID which is supposed to return the ID of the query. The InstallableUnitQuery overrides this method and provides different semantics. 

With the p2ql work, I'm not sure the getID method is needed on IQuery anymore.
Comment 1 Pascal Rapicault CLA 2010-02-03 10:55:45 EST
I would be happy to see that gone, or at least not marked API anymore.
Comment 2 Thomas Hallgren CLA 2010-02-03 11:34:12 EST
(In reply to comment #1)
> I would be happy to see that gone, or at least not marked API anymore.

So would I. I'm still at a position where I think all queries should be able to present themselves as expressions if possible. And I still believe it is possible for a majority of our queries. With that in place, there is no need to do introspection of the queries to find out what they are all about and hence, no need for the methods getID() and getProperty(String).

I suggest we get rid of both.
Comment 3 Ian Bull CLA 2010-02-03 12:53:08 EST
Created attachment 158072 [details]
patch

It's a pretty easy fix since nobody actually uses these methods.

This patch removes the methods
Removes the tests assoicated with them
Removes the methods from sublcasses
Removes the QueryHelper (and the package it was in)
Fixes up the manifests
Comment 4 Ian Bull CLA 2010-02-03 13:07:14 EST
releaed to head.