Bug 30108 - not clear what 'modifiers' in NamingConventions means
Summary: not clear what 'modifiers' in NamingConventions means
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 2.1   Edit
Hardware: PC Windows 2000
: P3 normal (vote)
Target Milestone: 2.1 M5   Edit
Assignee: Jim des Rivieres CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-01-23 12:29 EST by Adam Kiezun CLA
Modified: 2003-02-10 12:20 EST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Kiezun CLA 2003-01-23 12:29:04 EST 
20030121
we have 2 classes for handling modifiers (or flags if you wish)
Flags, and Modifier
they both contain the same methods  but it's not clear if they are compatible

so when NamingConventions.suggestGetter name has a parameter 'modifiers' 
i'm not sure what to feed it with
Comment 1 Philipe Mulet CLA 2003-01-24 04:07:55 EST 
Both are equivalent. The DOM one is actually a duplicate.

Both are implemented in term of the spec values (from the VM spec book), thus 
whichever constant you use should not make a difference.

I agree though it is confusing.

DOM Modifiers should redirect to Flags.
Comment 2 Jim des Rivieres CLA 2003-01-24 14:24:07 EST 
Added clarifying comments to Flags, Modifiers, and NamingConventions.
Comment 3 David Audel CLA 2003-02-10 12:20:14 EST 
Verified.