Bug 301072 - GnuMakefileGenerator does not handle path-spaces in RM command
Summary: GnuMakefileGenerator does not handle path-spaces in RM command
Status: NEW
Alias: None
Product: CDT
Classification: Tools
Component: cdt-build-managed (show other bugs)
Version: 7.0   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact: Jonah Graham CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-27 16:35 EST by Baltasar Belyavsky CLA
Modified: 2020-09-04 15:21 EDT (History)
1 user (show)

See Also:


Attachments
patch - applies to HEAD (8.34 KB, patch)
2010-01-27 16:37 EST, Baltasar Belyavsky CLA
no flags Details | Diff
updated patch - applies to HEAD (8.14 KB, patch)
2010-01-28 16:57 EST, Baltasar Belyavsky CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Baltasar Belyavsky CLA 2010-01-27 16:35:45 EST
Build Identifier: 7.0.0.I201001150805

Spaces in source file-names are handled during build, but not during clean.  The RM command is passed the make-style backslash-escaped paths, which is understood by neither 'rm' nor 'del'.

The attached patch fixes this problem by generating new make variables, of the form "<VAR>_QUOTED" for each make variable "<VAR>" that is generated for dependency-fragments and output-types.  The value of each "<VAR>_QUOTED" is a quoted version of the backslash-escaped value of "<VAR>".  These quoted versions of paths are then passed to the RM command.

Reproducible: Always

Steps to Reproduce:
1. Create a Cygwin-GCC project.
2. Add to it a source file that contains a space in its name.
3. Build the project.
-> The project builds OK.
4. Clean the project.
-> Clean fails.
Comment 1 Baltasar Belyavsky CLA 2010-01-27 16:37:20 EST
Created attachment 157471 [details]
patch - applies to HEAD
Comment 2 Baltasar Belyavsky CLA 2010-01-28 16:57:55 EST
Created attachment 157566 [details]
updated patch - applies to HEAD