Bug 300434 - [performance] Some inner classes should be static inner classes
Summary: [performance] Some inner classes should be static inner classes
Status: RESOLVED FIXED
Alias: None
Product: WTP Source Editing
Classification: WebTools
Component: wst.sse (show other bugs)
Version: 3.2   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 3.2 M6   Edit
Assignee: David Carver CLA
QA Contact: Nitin Dahyabhai CLA
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2010-01-21 15:08 EST by David Carver CLA
Modified: 2010-02-22 21:50 EST (History)
1 user (show)

See Also:
thatnitind: review+

Attachments
Make some inner classes static (10.25 KB, patch)
2010-01-21 16:17 EST, David Carver CLA 		no flags Details | Diff
mylyn/context/zip (21.80 KB, application/octet-stream)
2010-01-21 16:17 EST, David Carver CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Carver CLA 2010-01-21 15:08:50 EST 
There are several inner classes that should be made static for performance reasons.  This can reduce the sizes of the classes and help free them sooner for grabage collection.  I'll attach a patch to address this.
Comment 1 David Carver CLA 2010-01-21 16:17:14 EST 
Created attachment 156869 [details]
Make some inner classes static

This patch makes some inner classes static to help improve performance and sizes of the classes themselves.
Comment 2 David Carver CLA 2010-01-21 16:17:17 EST 
Created attachment 156870 [details]
mylyn/context/zip
Comment 3 Ian Tewksbury CLA 2010-02-17 16:17:09 EST 
Agreed.

In an effort to keep this bug from sitting here collecting dust I am marking Nick for review so it will hopefully get in sooner rather then later.
Comment 4 Nitin Dahyabhai CLA 2010-02-22 21:50:30 EST 
Also fixed the spelling of (private) fCurrentDocumnetRegionCache while I was in there.  Thanks, Dave.