Bug 299717 - Abstraction of the icon set
Summary: Abstraction of the icon set
Status: CLOSED FIXED
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 0.9   Edit
Hardware: PC Windows XP
: P3 normal with 1 vote (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact: Boris Bokowski CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-14 18:30 EST by Lars Vogel CLA
Modified: 2012-07-19 13:36 EDT (History)
8 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2010-01-14 18:30:18 EST
Hi,

e4 allows to style the UI Widgets via a css like style. 

Another important style element of the workbench is the used icon set. To my knowledge the icons are currently "hardcoded" into the model via the iconURI. 

Is it possible / does it make sense to add an abstraction to allow different icon sets in Eclipse? 

Best regards, Lars
Comment 1 Remy Suen CLA 2010-01-14 19:35:21 EST
I've brought this up in the past in a blog entry and on bug 281593.
http://blog.hantsuki.org/2009/06/25/native-widgets-check-native-icons-maybe-not/

I know Bogdan and Eric is coordinating together to get the CSS engine to style the model instead of the widgets.
Comment 2 Sebastien Moran CLA 2010-01-15 02:09:39 EST
Fully agree, it could be really nice to be able to provide iconsets. Besides to customise an RCP application, the icons are the last thing letting people say :"Ok that's an Eclipse application :)"
Comment 3 Boris Bokowski CLA 2010-01-15 11:08:58 EST
(In reply to comment #2)
> Fully agree, it could be really nice to be able to provide iconsets.

I agree as well, but just to set expectations, at IBM we don't have the resources to produce new icons.

I am all for making it easy to change the icons of course. Are there good open source icons we could use, or does anyone know a good designerdesigner who would be interested in having their work exposed to many potential customers? ;-)
Comment 4 Lars Vogel CLA 2010-01-15 11:13:19 EST
@Boris,

I think that it fine. This bug was not about providing new icons (which I also would like ;-)) but rather the possibility to replaced the existing icon set easily. 

This might also be a good chance to attract new contributors which come from a design background. Once the functionality is their we / Eclipse could for example start a design content.
Comment 5 Kai Toedter CLA 2010-01-15 11:19:32 EST
@Boris,

for the e4 contacts demo (and RCP Mail 2.0) I use the silk icon set, which is already Eclipse IP proved.

http://www.famfamfam.com/lab/icons/silk/
Comment 6 Sebastien Moran CLA 2010-01-15 11:27:37 EST
Of course I was not asking for new icons :) Just asking for the possibility to change them myself.

For our RCP applications we often use these two icon sets : 

- Tango Desktop project : http://tango.freedesktop.org
- Fam fam fam silk & flags : http://www.famfamfam.com/lab/icons/
Comment 7 Dénes Harmath CLA 2010-01-15 18:18:48 EST
I also support this to be able to customize the look and feel of my RCP apps in a consistent and manageale way.
I can also recommend two icon sets:
- Nuvola: http://www.icon-king.com/projects/nuvola/ (LGPL)
- Fugue: http://www.pinvoke.com/ (CC)
Does an icon set actually have to be Eclipse IP-approved to include it in an Eclipse plugin/RCP app?
Comment 8 Remy Suen CLA 2010-01-15 18:23:59 EST
(In reply to comment #7)
> Does an icon set actually have to be Eclipse IP-approved to include it in an
> Eclipse plugin/RCP app?

Well, if it's your own application then you're free to use your own icons be they free or paid for by a custom designer.

This bug is not about swapping icons in the base Eclipse installation, it's about making it easy for an RCP developer to switch icons.
Comment 9 Lars Vogel CLA 2010-01-15 18:58:31 EST
@Remy I agree. But once we have this capability the Eclipse IDE would also be able to use it. Derivated distros could further customize their tailored IDE based on Eclipse.
Comment 10 Susan McCourt CLA 2010-01-18 11:50:05 EST
See also bug 299716 - that bug is talking about how themes (colors and fonts) might be expressed in CSS.  Having the icons abstracted would cover all the JFace registry bases.

+1 on the general idea and a contest.  We're looking at having some design contests involving workbench styling, and it's only natural that the icon sets could be changed out to fit a style.  (I'm not saying the contests are necessarily the same, but that someone who spends time on a new style may wish to pick a new icon set to go with it).
Comment 11 Lars Vogel CLA 2010-01-21 17:38:26 EST
I would be nice to have also the option to change the icon. See also https://bugs.eclipse.org/bugs/show_bug.cgi?id=300271

Shall I open a new bug for this or is it ok to treat icons and the logo in the same bug?
Comment 12 Susan McCourt CLA 2010-01-24 16:43:28 EST
I just noticed bug 267844, which discusses this problem in 3.x.
Comment 13 Lars Vogel CLA 2012-07-19 13:36:34 EDT
Closing as fixed, as I could change this property in the application model via a processor.