Bug 299086 - EJB Timer wizard
Summary: EJB Timer wizard
Status: RESOLVED FIXED
Alias: None
Product: WTP EJB Tools
Classification: WebTools
Component: jst.ejb (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 3.3 M6   Edit
Assignee: Carl Anderson CLA
QA Contact: Kaloyan Raev CLA
URL:
Whiteboard: JavaEE6
Keywords: plan
Depends on:
Blocks:
 
Reported: 2010-01-07 17:47 EST by raccah CLA
Modified: 2011-03-10 00:27 EST (History)
6 users (show)

See Also:


Attachments
patch for the 2 Eclipse ejb projects that add EJB Timer EE 6 wizard (34.74 KB, patch)
2011-01-13 16:59 EST, ludo CLA
ccc: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description raccah CLA 2010-01-07 17:47:43 EST
Build Identifier: 

The GlassFish plugin provides a wizard that creates an EJB Timer class.  I mentioned this at today's Java EE 6 status meeting and they suggest I file an enhancement request to see if this would be useful to the general eclipse support.  We are investigating whether we can get some other glassfish plugin code contributed, and if we can, would be willing to donate this as well.


Reproducible: Always

Steps to Reproduce:
See the New->GlassFish->EJB Timer
Comment 1 Kaloyan Raev CLA 2010-01-14 10:36:54 EST
This is a good one. I bring it to the Helios plan. 

I would suggest to move the scheduling rules on a separate wizard page. It would be nice to have each scheduling attribute (day, month, minute, etc.) as a separate field, so proper validation could be implemented. We can still keep the current text box as a "preview" of the settings. 

I will post a UI mock-up later.
Comment 2 ludo CLA 2011-01-13 16:59:42 EST
Created attachment 186786 [details]
patch for the 2 Eclipse ejb projects that add EJB Timer EE 6 wizard
Comment 3 ludo CLA 2011-01-31 14:40:03 EST
1.  Can you confirm you authored 100% of the content you are contributing?
 Rochelle Raccah and myself for the patch, as Sun employees
2.  Do you have the rights to contribute the content to Eclipse?
yes
3.  Is the content being contributed under the Eclipse Public License?
yes
Comment 4 raccah CLA 2011-02-06 14:31:06 EST
I agree with Ludo's answers.
Comment 5 Carl Anderson CLA 2011-02-14 17:10:48 EST
Ludo,

In the attached patch, EjbTimerTemplate.java does not have an EPL header.  Can you please update that file with the proper copyright and license header, and reattach the patch?
Comment 6 ludo CLA 2011-02-14 19:24:15 EST
it is my understanding that this file is generated by the eclipse build system from the template ejbtimer.javajet in the org.eclipse.jst.j2ee.ejb bundle.
I am still not sure if it is needed in the repository...In any case, you can add the EPL license. We did not write this file, Eclipse IDE did.
Or try to delete it locally in your workspace to see if it is created again.

For example, similar MessageDrivenBeanTemplate.java file does not have an EPL license either.
Comment 7 alan james CLA 2011-02-25 21:12:10 EST
Hi, I'm new here and searched for qts timer bug...is that the same ejb timer?
Thanks
Comment 8 David Williams CLA 2011-02-28 21:58:05 EST
(In reply to comment #7)
> Hi, I'm new here and searched for qts timer bug...is that the same ejb timer?
> Thanks

No, not even close. :) Well ... I don't know what "qts timer bug" is, but assuming you mean QT's Timer, then no, not even close. EJB == Enterprise Java Bean.
Comment 9 Carl Anderson CLA 2011-03-10 00:25:36 EST
We should get this in before the UI/API freeze.
Comment 10 Carl Anderson CLA 2011-03-10 00:26:50 EST
Committed to HEAD for WTP 3.3 M6.

Note- I did not add the same EPL header as were added for the other templates- I wanted to commit Ludo's patch initially.