Bug 299079 - API cleanup in org.eclipse.equinox.p2.core
Summary: API cleanup in org.eclipse.equinox.p2.core
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.6 M5   Edit
Assignee: John Arthorne CLA
QA Contact:
URL:
Whiteboard:
Keywords: api
Depends on:
Blocks:
 
Reported: 2010-01-07 15:38 EST by John Arthorne CLA
Modified: 2010-01-13 15:11 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Arthorne CLA 2010-01-07 15:38:21 EST 
There are a few odds and ends that need cleaning up in the p2.core bundle:

1) ProvisionException

 -> Should move to API package

2) Event bus

 -> I'm wondering if we can get away with keeping it internal for now. I didn't see any external clients using it. It is currently exposed in ProvisioningSession API but it doesn't need to be (client can use session.getAgent().getService(..) isntead). The event bus is mainly for communication within the parts of the p2 implementation at the moment.

3) IServiceUI

 -> Functionality should be moved to an API package. Covered by bug 295399.
Comment 1 John Arthorne CLA 2010-01-07 15:39:49 EST 
I will take care of 1). Susan, what do you think on the event bus? I was surprised to see its usage within the UI is now almost non-existent. If we could avoid exposing this in 3.6 it would give us some freedom to revisit and change the event story in the future (for example possibly using event admin).
Comment 2 John Arthorne CLA 2010-01-07 16:07:31 EST 
(In reply to comment #1)
> I was surprised to see its usage within the UI is now almost non-existent.

This was based on reviewing references to IProvisioningEventBus, of which there are only 3 refs in the UI. However I see after more digging there is a fair amount of use of the event bus in the UI, it's just funneled through a small number of helper methods so direct exposure to IProvisioningEventBus is low. I guess this comes down to whether we have a goal of the UI being "API-clean" in its usage of p2 core this release.
Comment 3 Pascal Rapicault CLA 2010-01-11 10:39:12 EST 
I don't think we need to worry about making the p2 UI completely API clean.
Comment 4 John Arthorne CLA 2010-01-13 15:04:55 EST 
Marking this fixed. The event bus will stay provisional, and issue 3) IServiceUI is tracked by a separate bug.
Comment 5 John Arthorne CLA 2010-01-13 15:11:43 EST 
Really closing this time.