Bug 298214 - [reconciler] Metadata generated twice when reconciling dropins
Summary: [reconciler] Metadata generated twice when reconciling dropins
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.6   Edit
Assignee: DJ Houghton CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2009-12-18 13:49 EST by John Arthorne CLA
Modified: 2010-05-06 10:10 EDT (History)
3 users (show)

See Also:


Attachments
Profiler output showing double metadata generation on 3.4.2 (44.92 KB, text/plain)
2009-12-18 13:51 EST, John Arthorne CLA
no flags Details
Profiler output showing single metadata generation on 3.6 (33.68 KB, text/plain)
2010-05-06 10:08 EDT, DJ Houghton CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description John Arthorne CLA 2009-12-18 13:49:22 EST
When an extension location is added in dropins, it looks like metadata generation happens twice for the same features and plugins. It happens when the ExtensionLocationMetadataRepository is created, and again when the ExtensionLocationArtifactRepository is created.

I will attach some profiler output from 3.4.2, but DJ and I also noticed this when running on 3.6 HEAD earlier this week.
Comment 1 John Arthorne CLA 2009-12-18 13:51:07 EST
Created attachment 154805 [details]
Profiler output showing double metadata generation on 3.4.2
Comment 2 Simon Kaegi CLA 2009-12-21 22:12:45 EST
In 3.6 there were some changes done when we switched to the publisher that cause us to rescan however the same problem in 3.4.2 surprises me as that was optimized. I wonder if we're looking at the dropins folder getting scanned and then a subfolder getting scanned instead of a double scanning of the same folder.
Comment 3 DJ Houghton CLA 2010-04-16 16:37:06 EDT
Adding target milestone so we don't forget about this. 

Simon: fyi John and/or I may look in this area when we look at reconciler performance in the next little while.
Comment 4 Simon Kaegi CLA 2010-04-22 21:46:29 EDT
I'm not planning on doing anything more for this 3.6
Comment 5 DJ Houghton CLA 2010-05-06 10:08:57 EDT
Created attachment 167308 [details]
Profiler output showing single metadata generation on 3.6
Comment 6 DJ Houghton CLA 2010-05-06 10:10:38 EDT
I did some profiling with the latest builds and we are no longer generating metadata twice. It is generated once when we first create the extension location repository (when loading the metadata repository) and then when we access the artifact repository we just load the one we already created.

I've attached the profiler output from one of this week's builds.

Closing.