Bug 297717 - Compare with base: edits not detected
Summary: Compare with base: edits not detected
Status: RESOLVED FIXED
Alias: None
Product: Subversive
Classification: Technology
Component: UI (show other bugs)
Version: 0.7   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: Kepler M7   Edit
Assignee: Igor Burilo CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-14 04:34 EST by Igor Burilo CLA
Modified: 2015-07-14 18:20 EDT (History)
3 users (show)

See Also:


Attachments
Screenshot of plugin spy popups (31.40 KB, image/png)
2013-04-24 06:38 EDT, David Balažic CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Igor Burilo CLA 2009-12-14 04:34:14 EST
From newsgroup:

https://bugs.eclipse.org/bugs/show_bug.cgi?id=41564

I have the problem described in this bug, but with subversive.

That is:
 - edit and save a file
 - right click and select Compare With / Base from Working Copy
 - in the compare editor, type something in an unchanged part of the file (left pane)
 - save (ctrl-s)

Expected result:
 - the new difference is marked as such

Actual result:
 - the new difference is not marked at all

If I do the same, but select Compare With / Local History..., then it works fine, so it must be something with subversive, I guess.


Eclipse JEE 3.5.1 with subversive and SVNKit (latest versions as of writing, if there is never when you reply, I'll try them...)
Comment 1 David Balažic CLA 2010-04-06 12:06:39 EDT
Same with 3.5.2

Eclipse Java EE IDE for Web Developers.

Build id: 20100218-1602

  SVNKit 1.3.2 Implementation (Optional)	2.2.1.I20091215-1700	org.polarion.eclipse.team.svn.connector.svnkit16.feature.group
  Subversive SVN Team Provider (Incubation)	0.7.8.I20100326-1700	org.eclipse.team.svn.feature.group
  Subversive SVN Connectors	2.2.1.I20091215-1700	org.polarion.eclipse.team.svn.connector.feature.group
Comment 2 David Balažic CLA 2013-04-24 06:37:47 EDT
As described in bug 176690 comment 14 this (updating the compare window) does not work when doing a "Compare With / Base Revision", but works when opening the same compare from the Synchronize view.

Both editors look the same, only tab title is different.
The "Compare With / Base Revision" has a title like "Compare _filename_ <workspace> and versions"  (_filename_ is the actual filename)
The one opened from the Synchronize view has a title like "_filename_"

Plugin spy reports the same information for both (attached).

Now I'm using
Eclipse Java EE IDE for Web Developers.
Version: Juno Service Release 2
Build id: 20130225-0426

and
Subclipse (Required)	1.8.20	org.tigris.subversion.subclipse.feature.group	tigris.org


So this is not a Subversive issue, but probably Platform/Compare, can someone change this? I can't.
Comment 3 David Balažic CLA 2013-04-24 06:38:23 EDT
Created attachment 230070 [details]
Screenshot of plugin spy popups
Comment 4 Jörg Thönnes CLA 2013-04-25 07:59:35 EDT
Alexander, in this case this should be moved to the Platform Team support?
Comment 5 Alexander Gurov CLA 2013-04-25 08:04:58 EDT
(In reply to comment #4)
> Alexander, in this case this should be moved to the Platform Team support?

Hello Jörg,

I'm not sure about this one, I think I'd better check it first, since it's said everything works fine when comparing with local history.
Comment 6 Alexander Gurov CLA 2013-04-27 12:50:24 EDT
Thank you for pointing out this issue for me. It is fixed now.

P.S.
(In reply to comment #2)
> and
> Subclipse
> (Required)	1.8.20	org.tigris.subversion.subclipse.feature.group	tigris.org
> 
> So this is not a Subversive issue, but probably Platform/Compare, can someone
> change this? I can't.
David, thank you for your help. Actually it really was an issue in Subversive: in order to work properly CompareEditorInput should be subclassed from a different class. So, if it doesn't work in Subclipse - the reason most likely is the same.
Comment 7 David Balažic CLA 2015-07-14 17:15:36 EDT
This again does not work with:

Eclipse IDE for Java Developers

Version: Luna Service Release 2 (4.4.2)
Build id: 20150219-0600

eclipse platform 4.4.2

  Subversive SVN Team Provider	2.0.4.I20150123-1700	org.eclipse.team.svn.feature.group	Eclipse.org

  JavaHL 1.8.10 Win64 Binaries (Optional)	4.1.2.I20141224-1700	org.polarion.eclipse.team.svn.connector.javahl18.win64.feature.group	Polarion Software
Comment 8 David Balažic CLA 2015-07-14 18:20:14 EDT
Also same ("same" == as described in initial comment) with:

Eclipse for Testers

Version: Mars Release (4.5.0)
Build id: 20150621-1200

  Subversive SVN Team Provider	3.0.0.I20150529-1700	org.eclipse.team.svn.feature.group	Eclipse.org