Bug 297320 - [nls tooling] Add more tests for Find Broken Externalized Strings
Summary: [nls tooling] Add more tests for Find Broken Externalized Strings
Status: RESOLVED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 3.6   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.6 M5   Edit
Assignee: Deepak Azad CLA
QA Contact:
URL:
Whiteboard:
Keywords: test
Depends on:
Blocks:
 
Reported: 2009-12-09 06:05 EST by Dani Megert CLA
Modified: 2010-01-25 06:04 EST (History)
0 users

See Also:


Attachments
fix (9.30 KB, patch)
2010-01-23 05:05 EST, Deepak Azad CLA
no flags Details | Diff
patch to reproduce the problem and test the test (1.17 KB, patch)
2010-01-23 05:07 EST, Deepak Azad CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2009-12-09 06:05:09 EST
I20091209-0100.

See bug 247012 comment 21.
Comment 1 Deepak Azad CLA 2010-01-23 05:05:12 EST
Created attachment 157029 [details]
fix

Added a new test case plus modified NLSSearchTestHelper.

Reasoning : In a Accessor class the match is 'public static String Client_s1;', however in other files (Client and properties) it is  just 'Client_s1'.
Comment 2 Deepak Azad CLA 2010-01-23 05:07:15 EST
Created attachment 157030 [details]
patch to reproduce the problem and test the test

With this patch applied the newly added test will fail.
Comment 3 Dani Megert CLA 2010-01-25 06:04:54 EST
Thanks for the patch.

Fixed in HEAD.
Available in builds >= I20100125-1300.