Community
Participate
Working Groups
The wizard for adding JavaScript libraries to a project could make use of icons for better readability.
Created attachment 153710 [details] dialog with icons
Created attachment 153711 [details] patch patch changes wizard implementation to use Table instead of List. Icons are provided via standard Eclipse Adapter API
Created attachment 153712 [details] patch for firefox and ie patch for o.e.wst.jsdt.support.firefox and o.e.wst.jsdt.support.ie to implement adapter factories necessary to provide images. I took liberty to reorganize icons a bit in those plugins, I created bundle activators which now manage icons and updated other code to also use them. Icons would have to be manually moved from source code to toplevel icons folder in each plug-in, as patch doesn't handle binary changes.
Created attachment 153714 [details] patch v2 I missed part of changes in earlier patch, that I'm going to mark as obsolete now.
Jacke, Is there some reason that both WizardAdapterFactory classes use the same package, org.eclipse.wst.jsdt.internal.ui.wizards.buildpaths, but one uses the bundles' ImageRegistry and the other doesn't (potentially leaking the Images it creates)?
good catch, IE WizardAdapterFactory should be indeed: return Activator.getDefault().getImageRegistry().get(Activator.IE_SMALL); instead of return AbstractUIPlugin.imageDescriptorFromPlugin(Activator.PLUGIN_ID, Activator.IE_SMALL).createImage();
Looks like most things work well, once the icons are moved, but BaseLibraryWizardPage (for one) throws a NPE if you finish the wizard as you now can without showing the page. The controls aren't created as expected before finish() is called, plus I'd rather complete this by making sure un-adapted pages at least show the default library image. Attachment 153710 [details] is an improvement over the current unadorned list, but it look pretty odd to only show images for 2 of the 4 built-in add-on containers.
Looking at this a little more closely, I'm not sure we're legally allowed to ship/show those images without a CQ, and we don't have images, either. Jacek, were you going to provide them?
sorry for not responding earlier, I was pretty sure that this icons already exist in JSDT, but couldn't find them... ...until today! /org.eclipse.wst.jsdt.support.firefox/src/org/eclipse/wst/jsdt/core/compiler/libraries/FireFoxSmall.gif /org.eclipse.wst.jsdt.support.ie/src/org/eclipse/wst/jsdt/core/compiler/libraries/ie_small.gif I can't say for sure now, but maybe my patches require moving the files from Java packages to their own separate dirs. It seems that they are used already in existing JSDT code.
@Jacek: could you please provide this patch via Gerrit? https://wiki.eclipse.org/JSDT/Development#Gerrit_Reviews
