296708 – [DOM/AST] clarify setters when createASTs(..) is used

Bug 296708 - [DOM/AST] clarify setters when createASTs(..) is used

Summary: [DOM/AST] clarify setters when createASTs(..) is used

Status:	VERIFIED FIXED

Alias:	None

Product:	JDT
Classification:	Eclipse Project
Component:	Core (show other bugs)
Version:	3.6
Hardware:	PC Windows XP

Importance:	P3 normal (vote)
Target Milestone:	3.6 M4
Assignee:	Olivier Thomann
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2009-12-02 10:32 EST by Olivier Thomann
Modified:	2009-12-08 03:02 EST (History)
CC List:	3 users (show)

See Also:

Attachments
Proposed fix (9.68 KB, patch) 2009-12-02 12:50 EST, Olivier Thomann	no flags	Details \| Diff
Fix for typos (3.87 KB, patch) 2009-12-03 09:24 EST, Olivier Thomann	no flags	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Olivier Thomann

2009-12-02 10:32:30 EST

Fup of bug 288211, we should clarify that some setters in ASTParser have no effect when createASTs(..) is used. They are only pertinent in the context of the createAST(..) call.

Comment 1 Olivier Thomann

2009-12-02 12:50:05 EST

Created attachment 153624 [details]
Proposed fix

Proposed changes in the doc

Comment 2 Olivier Thomann

2009-12-02 13:33:27 EST

Released for 3.6M4.
Might be adjusted if needed.

Comment 3 Markus Keller

2009-12-03 05:02:28 EST

The first note looks good, but all the others are missing a 'when', e.g. :
	 * <p>This source is not used the AST is built using 
	                             ^

The note for setUnitName(String) should say "This name", not "This source".

Comment 4 Olivier Thomann

2009-12-03 09:24:28 EST

Created attachment 153726 [details]
Fix for typos

Comment 5 Olivier Thomann

2009-12-03 09:25:11 EST

Closing as FIXED.

Comment 6 Ayushman Jain

2009-12-08 01:47:49 EST

Verified for 3.6M4