Bug 296418 - Bad performance of Hyperlinks in Java consoles
Summary: Bad performance of Hyperlinks in Java consoles
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 3.6   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 3.6 M4   Edit
Assignee: JDT-Debug-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2009-11-29 14:14 EST by Markus Keller CLA
Modified: 2009-11-30 11:40 EST (History)
1 user (show)

See Also:

Attachments
Fix (5.04 KB, patch)
2009-11-29 14:14 EST, Markus Keller CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2009-11-29 14:14:03 EST 
Created attachment 153308 [details]
Fix

I20091124-0800

When I click a type name hyperlink in a Java console, I often have to wait so
long that I would have been faster by using the Open Type dialog.

AFAICS, the reason is that OpenTypeAction#findTypeInWorkspace(String) does a
full search for declarations of the given type, thereby resolving source
positions, etc. for every match. But since that's not required here,
SearchEngine#searchAllTypeNames(..) can be used, which is much faster
(optimized for the Open Type dialog), see attached patch.
Comment 1 Michael Rennie CLA 2009-11-30 11:38:05 EST 
Patch works awesomely, applied to HEAD
Comment 2 Michael Rennie CLA 2009-11-30 11:40:01 EST 
verified, thanks for the patch Markus.