Bug 295946 - Create a default ModelProviderFactory for Connector 1.6
Summary: Create a default ModelProviderFactory for Connector 1.6
Status: RESOLVED FIXED
Alias: None
Product: WTP Java EE Tools
Classification: WebTools
Component: jst.j2ee (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: 3.2 M4   Edit
Assignee: Carl Anderson CLA
QA Contact: Chuck Bridgham CLA
URL:
Whiteboard: JavaEE6
Keywords: plan
Depends on:
Blocks:
 
Reported: 2009-11-23 17:56 EST by Carl Anderson CLA
Modified: 2010-01-27 16:11 EST (History)
0 users

See Also:


Attachments
Create a default Connector16ModelProviderFactory (28.62 KB, patch)
2009-11-23 18:02 EST, Carl Anderson CLA
no flags Details | Diff
Two minor fixes. (2.81 KB, patch)
2009-11-23 18:57 EST, Carl Anderson CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carl Anderson CLA 2009-11-23 17:56:45 EST
As a continuation of bug 252615, support for a Java EE 6 version of the JCA specification is being added.  We need to update the ConnectorFacetInstallDelegate to utilize the appropriate ModelProvider, as implemented in a ModelProviderFactory.
Comment 1 Carl Anderson CLA 2009-11-23 17:59:32 EST
Also note that, since JCA 1.6 is new as of Java EE 6, the content describer is org.eclipse.jst.jee.ee6connectorDD
Comment 2 Carl Anderson CLA 2009-11-23 18:02:15 EST
Created attachment 152909 [details]
Create a default Connector16ModelProviderFactory

I also tweaked ConnectorComponentImportDataModelProvider to set the GENERATE_DD flag to false, with a corresponding change to ConnectorFacetInstallDelegate to not generate the deployment descriptor if that is set to false.
Comment 3 Carl Anderson CLA 2009-11-23 18:57:33 EST
Created attachment 152911 [details]
Two minor fixes.

The legacy validator needs to be disabled for JCA 1.6
Also, the displayName was not being properly set due to a ClassCastException.
Comment 4 Carl Anderson CLA 2009-11-23 18:58:11 EST
Committed both patches to HEAD.
Comment 5 Carl Anderson CLA 2009-12-03 22:30:08 EST
This was committed to HEAD