Comment 1 wdorninger 2009-11-18 12:27:21 EST

This is the aspect I'm trying to add

package com.test.aspects;

import javax.persistence.EntityManager;
import javax.persistence.PersistenceContext;

public aspect SpringConfigurableMixin {

    public static interface HasEntityManager {
      EntityManager getEntityManager();
    }
    
    declare @type : (@Entity *) : @Configurable(autowire = Autowire.BY_TYPE, preConstruction = true);
    
    declare parents : (@Entity *) implements HasEntityManager;
    
    @PersistenceContext
    transient private EntityManager HasEntityManager.em;
   
    public EntityManager HasEntityManager.getEntityManager() {
       return em;
    }    
}

Comment 2 wdorninger 2009-11-18 12:36:34 EST

The culprit seems to be the "decleare @type" which causes the exception. When its commented out there is no NullPointerException

Comment 3 Andrew Clement 2009-11-18 12:47:02 EST

I fixed a similar bug to this yesterday (although the fix is not in AJDT yet).  In that case is was happening if your declare statements used an annotation type that you hadn't imported.  Before the compile error about the missing import is reported, the code that builds the model crashes because it is missing.  Are both your annotation types imported?

Comment 4 wdorninger 2009-11-18 15:03:02 EST

Thanks for the quick reply. 

You are right 

import javax.persistence.Entity;
import org.springframework.beans.factory.annotation.Configurable;

were not imported however even after importing them I get the same NullPointerException.

Comment 5 Andrew Clement 2009-11-18 15:20:00 EST

susprised you get the NPE even after the import.  Is Autowire imported too?

Comment 6 wdorninger 2009-11-18 15:36:31 EST

Yes all the imports are done - here the full aspect. I also tried to simplify it by omitting the parameters for the annotation however no luck.

package com.j4fe.aspects;

import javax.persistence.EntityManager;
import javax.persistence.PersistenceContext;
import javax.persistence.Entity;
import org.springframework.beans.factory.annotation.Configurable;
import org.springframework.beans.factory.annotation.Autowired;

public aspect SpringConfigurableMixin {

    public static interface EntityManagerAware {
      EntityManager getEntityManager();
    }
    
   
    // not working 
    // declare @type : (@Entity *) : @Configurable(autowire = Autowire.BY_TYPE, preConstruction = true);
    
    // also not working
    // declare @type : (@Entity *) : @Configurable
    
    declare parents : (@Entity *) implements EntityManagerAware;
    
    @PersistenceContext
    transient private EntityManager EntityManagerAware.entityManager;
   
    public EntityManager EntityManagerAware.getEntityManager() {
       return entityManager;
    }    
}

Comment 7 Andrew Clement 2009-11-18 16:27:44 EST

your import says Autowired but your code says Autowire - is that just a typo in putting the snippet into bugzilla?

Comment 8 wdorninger 2009-11-19 02:49:30 EST

At the end I did not even try with parameters anymore - I only uncommented this line and also got a NullPointerException (both annotations Entity and Configurable are imported)

declare @type : (@Entity *) : @Configurable

Comment 9 Andrew Clement 2010-01-25 17:01:37 EST

I took the sample code, obtained the spring and persistence dependencies, but I can still only make it fail on an old AJDT.  Are you sure when you had everything imported that you also had Autowire imported, because I don't see the import for that in the sample?

Once I upgraded AJDT, everything behaved as expected and the NPE went away.

Can you let me know what version of AJDT you are using so I can persue this further, thanks.

Comment 10 Andrew Clement 2010-03-10 11:55:55 EST

let me know the AJDT version if you are still having this problem.