Bug 294731 - Specify value type of JAVADOC_LOCATION_ATTRIBUTE_NAME
Summary: Specify value type of JAVADOC_LOCATION_ATTRIBUTE_NAME
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.5   Edit
Hardware: All All
: P3 trivial (vote)
Target Milestone: 3.6 M4   Edit
Assignee: Olivier Thomann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-10 08:01 EST by Dani Megert CLA
Modified: 2009-12-08 03:22 EST (History)
3 users (show)

See Also:

Attachments
Proposed fix (747 bytes, patch)
2009-11-10 11:01 EST, Olivier Thomann CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2009-11-10 08:01:22 EST 
I20091103-0941.

The Javadoc of org.eclipse.jdt.core.IClasspathAttribute.JAVADOC_LOCATION_ATTRIBUTE_NAME should mention what type the corresponding value has to have (String representation of an URL in this case).
Comment 1 Olivier Thomann CLA 2009-11-10 11:01:49 EST 
Created attachment 151838 [details]
Proposed fix
Comment 2 Olivier Thomann CLA 2009-11-10 11:17:35 EST 
Released for 3.6M4.
Comment 3 Curtis Windatt CLA 2009-11-10 11:42:48 EST 
Thanks for the quick fix.
Comment 4 Dani Megert CLA 2009-11-11 02:40:02 EST 
Olivier, it should be "an URL" instead of "a URL".
Comment 5 Olivier Thomann CLA 2009-11-11 14:43:21 EST 
(In reply to comment #4)
> Olivier, it should be "an URL" instead of "a URL".
According to what I know about the English grammar, as soon as the "sound" of the 'uU' is a consonant sound, no 'n' is required.

I think it is "a university" or "a unicorn". This is the same 'u' sound as in "url".

Wikipedia seems to agree with this.
See http://en.wikipedia.org/wiki/Uniform_Resource_Locator

So I would leave it as is.
Comment 6 Dani Megert CLA 2009-11-12 03:11:24 EST 
Sorry, you are right, it is pronounced as yü är el and hence it's "a URL".
Comment 7 Srikanth Sankaran CLA 2009-12-08 03:22:02 EST 
Verified for 3.6M4 using Build id: I20091207-1800