Bug 294448 - Path Mapping dialog issues
Summary: Path Mapping dialog issues
Status: NEW
Alias: None
Product: CDT
Classification: Tools
Component: cdt-debug (show other bugs)
Version: 6.1   Edit
Hardware: PC Linux-GTK
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: cdt-debug-inbox@eclipse.org CLA
QA Contact: Jonah Graham CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-06 07:48 EST by James Blackburn CLA
Modified: 2020-09-04 15:21 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description James Blackburn CLA 2009-11-06 07:48:22 EST 
The path mapping dialog has a "Compilation Path" (on the left hand side) and a "Local file system path:" on the right hand side.

Issues:
  - The left field is a normal editable text field, the right hand field isn't. 
  - Clicking on the path browse shows a file browser rooted in Eclipse's CWD rather than a browse dialog located at the value of the current "Local file system path" location.
Comment 1 John Cortell CLA 2009-11-06 07:58:51 EST 
Indeed. I've found the first point particularly annoying, as I can type "c:\cygdrive" much quicker than I can navigate to it in the directory browser.
Comment 2 Nobody - feel free to take it CLA 2009-11-06 09:07:31 EST 
My fault.
Comment 3 Nobody - feel free to take it CLA 2009-11-09 08:28:34 EST 
The second issue is easy to fix. But for the first one we need to implement a new CellEditor: a combination of TextCellEditor and DialogCellEditor.
In any cases the previous implementation required openning two extra dialogs for the same task.
I can commit the second fix to 6.0.2 and try to find some time for the first. Suggestions?
Comment 4 John Cortell CLA 2009-11-09 10:28:30 EST 
(In reply to comment #3)
> The second issue is easy to fix. But for the first one we need to implement a
> new CellEditor: a combination of TextCellEditor and DialogCellEditor.
> In any cases the previous implementation required openning two extra dialogs
> for the same task.
> I can commit the second fix to 6.0.2 and try to find some time for the first.
> Suggestions?

Mikhail, the current workflow is definitively better than the previous one; so thanks for that. 

Being being forced to navigate to the local directory is inconvenient, but I don't know that it warrants the time to create a custom CellEditor. Since James and I are the one who've complained about it, I suppose one of us should invest the time. I can't at the moment, though.
Comment 5 Nobody - feel free to take it CLA 2009-11-09 12:24:48 EST 
(In reply to comment #4)

Fine. I have committed fix for the second issue to the HEAD and 6.02 branch.

> Since James and I are the one who've complained about it, I suppose one of us should invest
> the time. I can't at the moment, though.

John, I like your logic :) but feel responsible for it too. I just don't know how it's supposed to work with keyboard and don't want to spend too much time investigating it. I'll keep the bug open and assigned to me.