Bug 293996 - [preferences] Invalid preference page path: JavaScript
Summary: [preferences] Invalid preference page path: JavaScript
Status: RESOLVED FIXED
Alias: None
Product: JSDT
Classification: WebTools
Component: General (show other bugs)
Version: 3.1   Edit
Hardware: All All
: P3 minor (vote)
Target Milestone: 3.2 M6   Edit
Assignee: Nitin Dahyabhai CLA
QA Contact: Nitin Dahyabhai CLA
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2009-11-02 16:45 EST by Michael Rennie CLA
Modified: 2010-03-03 11:13 EST (History)
3 users (show)

See Also:

Attachments
fix (808 bytes, patch)
2009-11-02 16:45 EST, Michael Rennie CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Rennie CLA 2009-11-02 16:45:38 EST 
Created attachment 151128 [details]
fix

I20091027-0100 + org.eclipse.wst.jsdt.ui from HEAD

Opening the preferences dialog the first time Eclipse starts (target or host)
always results in an entry in my log:

Invalid preference page path: JavaScript

The reason is because the main JavaScript preference page specifies a parent
node that does not exist (org.eclipse.wst.html.ui.preferences.web for
reference).
Comment 1 Nitin Dahyabhai CLA 2009-11-03 00:38:35 EST 
Hmm, this is problematic because when we have the HTML component installed, we actually want the JavaScript pages to show up under the "Web" category it contributes.  Even then, though, there's value in not requiring them to properly run the core JavaScript IDE.  Any suggestions?
Comment 2 Michael Rennie CLA 2009-11-03 09:40:54 EST 
Maybe there is some way to suppress the error from being reported? 

Paul is there anything we can do here to say "if the Web root page is available make the JavaScript one a child, else make the JavaScript page a root?"
Comment 3 Paul Webster CLA 2009-11-03 09:51:46 EST 
(In reply to comment #2)
> Paul is there anything we can do here to say "if the Web root page is available
> make the JavaScript one a child, else make the JavaScript page a root?"

I don't believe so.  Is the preference page showing up (just in the root) or is it not showing up at all (which I would think is a problem)?

Another option would be to add the category node.  Oleg, what would be the easiest way to deal with this scenario:

If the web stuff is not installed, generate a container page for the JavaScript preference page.

It looks like it does appear at the top: org.eclipse.ui.internal.registry.CategorizedPageRegistryReader.processNodes()

PW
Comment 4 Michael Rennie CLA 2009-11-03 10:08:38 EST 
(In reply to comment #3)
> 
> I don't believe so.  Is the preference page showing up (just in the root) or is
> it not showing up at all (which I would think is a problem)?

The JavaScript page shows up as the root page with only JSDT available
Comment 5 Nitin Dahyabhai CLA 2009-11-03 15:04:31 EST 
So you don't (In reply to comment #3)
> I don't believe so.  Is the preference page showing up (just in the root) or is
> it not showing up at all (which I would think is a problem)?
> 
> Another option would be to add the category node.  Oleg, what would be the
> easiest way to deal with this scenario:
> 
> If the web stuff is not installed, generate a container page for the JavaScript
> preference page.
> 
> It looks like it does appear at the top:
> org.eclipse.ui.internal.registry.CategorizedPageRegistryReader.processNodes()

Any idea what name it would pick for this node?  I'm all for the current behavior sans log output.
Comment 6 Nitin Dahyabhai CLA 2010-02-02 17:46:02 EST 
Applied, thanks Michael.