Bug 293338 - [api] Comments about the metadata package
Summary: [api] Comments about the metadata package
Status: CLOSED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: 3.5   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: 3.6 M6   Edit
Assignee: Pascal Rapicault CLA
QA Contact:
URL:
Whiteboard:
Keywords: api
Depends on:
Blocks:
 
Reported: 2009-10-26 13:07 EDT by Pascal Rapicault CLA
Modified: 2010-03-08 22:26 EST (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Pascal Rapicault CLA 2009-10-26 13:07:19 EDT
IU
- Add several licenses to the IU
- Completely remove the concept of flavor
- Think about promoting the concept of lifecycle on patches to InstallableUnit
- Review the need for isSingleton? Can it be changed to be a cardinality?
- What happens to the touchpoint type
- what is the grammar of the IU ID?

IUPatch
- does it make sense for getLifeCycle to use the OR'ing
- getApplicabilityScope, does it make sense to use OR'ing

ILicense
- Where do we put the unique identifier for the license does it replace the digest?
- What do we use the getLocation for?

IRequiredCapability / IProvidedCapability
- Add a notion of type / value
- See if we can do w/o the filter
- getSelectors is not used... remove it
- change is multiple to be a cardinatlity
- How to cleanly deal with negation (isNegation is ugly)?

IUpdateDescriptor 
- We should be able to use a requiredCapability to identify what it is an update of rather than inventing something else.

MetadataFactory
- Do we want to make that non static and allow for the metadata factory to be replaced?
- Do we need to have a method to create instance of ArtifactKey?
- Do we get anything by using a fluent API?
Comment 1 Susan McCourt CLA 2009-10-26 14:29:48 EDT
(In reply to comment #0)
> ILicense
> - Where do we put the unique identifier for the license does it replace the
> digest?
> - What do we use the getLocation for?

If a location is provided for a license, the UI currently provides a link to the license on the license property page and opens a browser when the user selects a link.

> IUpdateDescriptor 
> - We should be able to use a requiredCapability to identify what it is an
> update of rather than inventing something else.

See bug 290976.  We should have an update description location property(and should start using the update description property).

Not API related, but see bug 233030.
Comment 2 Andrew Niefer CLA 2009-10-28 15:25:04 EDT
MetadataFactory :
I propose a new method 
ITouchpointData MetadataFactory#mergeTouchpointData(ITouchpointData initial, Map incomingInstructions)
An implementation of this exists in the publisher AdviceFileAdvice#getTouchpointData
Comment 3 Pascal Rapicault CLA 2010-03-08 22:26:25 EST
All the issues in here have been fixed.