Bug 293266 - [Accessibility] - Text box and its label are not connected
Summary: [Accessibility] - Text box and its label are not connected
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 3.6   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.6 M3   Edit
Assignee: Michael Rennie CLA
QA Contact:
URL:
Whiteboard:
Keywords: accessibility
Depends on:
Blocks:
 
Reported: 2009-10-25 12:35 EDT by Sérgio Neves CLA
Modified: 2009-10-26 14:29 EDT (History)
5 users (show)

See Also:
curtis.windatt.public: review+

Attachments
fix (6.27 KB, patch)
2009-10-26 12:15 EDT, Michael Rennie CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sérgio Neves CLA 2009-10-25 12:35:15 EDT 
User-Agent:       Mozilla/4.0 (compatible; MSIE 7.0; Windows NT 5.1; .NET CLR 2.0.50727; .NET CLR 3.0.04506.648; .NET CLR 3.5.21022; .NET CLR 3.0.4506.2152; .NET CLR 3.5.30729)
Build Identifier: I20091020-0931

Screen reader doesn't announce the label associated with the main class text box of main tab of launch configurations' properties

Reproducible: Always

Steps to Reproduce:
1. Go to both menu Run -> Run Configurations... and Run -> Debug Configurations... 
2. Select a configuration and go to the Main tab.
3. Press tab key till the text box associated with the main class is focused.
Expected result: the screen reader should announce: Main class edit
Actual result: the screen reader announces only: edit (doesn't announce the associated label). 
It's difficult for blind people to see what the text box is for.
Comment 1 Francis Upton IV CLA 2009-10-25 16:56:57 EDT 
I think launch config is part of JDT UI, if not please send this to the right place.
Comment 2 Kevin Barnes CLA 2009-10-26 11:47:46 EDT 
Car, do you have any advice here?
Comment 3 Michael Rennie CLA 2009-10-26 11:49:41 EDT 
Kevin tested this on Mac using Voiceover and I tested using Orca on Linux, reproducing the bug on moth other platforms...
Comment 4 Michael Rennie CLA 2009-10-26 12:01:22 EDT 
Talking with Kevin we should be using a ControlAccessibleListener to set the text that must be said for the text widget since we only get that label-widget mapping for free when a label directly proceeds the text. In this case we need to set it to say the group text when the text box takes focus.

Patch coming...
Comment 5 Michael Rennie CLA 2009-10-26 12:15:07 EDT 
Created attachment 150527 [details]
fix

patch adds in the two needed ControlAccessibleListener#addListener(..) calls and removes some duplicated SWT code.
Comment 6 Michael Rennie CLA 2009-10-26 12:15:43 EDT 
please verify Curtis
Comment 7 Michael Rennie CLA 2009-10-26 12:17:06 EDT 
forgot to mention...patch applied to HEAD.
Comment 8 Curtis Windatt CLA 2009-10-26 12:37:44 EDT 
Verified using Orca on Linux.