Bug 293056 - Performance degradation in org.eclipse.jdt.internal.core.DeltaProcessingState.resourceChanged(IResourceChangeEvent)
Summary: Performance degradation in org.eclipse.jdt.internal.core.DeltaProcessingState...
Status: CLOSED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.6   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Jay Arthanareeswaran CLA
QA Contact:
URL:
Whiteboard:
Keywords: needinfo, performance
Depends on:
Blocks:
 
Reported: 2009-10-22 11:10 EDT by Kenneth Cheung CLA
Modified: 2009-11-27 14:20 EST (History)
1 user (show)

See Also:

Attachments
Plugin patch (4.15 MB, application/octet-stream)
2009-11-01 23:52 EST, Jay Arthanareeswaran CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Cheung CLA 2009-10-22 11:10:57 EDT 
User-Agent:       Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 5.1; Trident/4.0; GTB6; .NET CLR 1.1.4322; .NET CLR 2.0.50727; .NET CLR 3.0.04506.30; .NET CLR 3.0.04506.648; OfficeLiveConnector.1.3; OfficeLivePatch.0.0; .NET CLR 3.0.4506.2152; .NET CLR 3.5.30729)
Build Identifier: I3422I20090911_20090911_1825

In the performance tests in our adopting product comparing with a build based on Eclipse 34I20080910, the method:
org.eclipse.jdt.internal.core.DeltaProcessingState.resourceChanged(IResourceChangeEvent)
is having a a degradation (2921ms vs 78ms), in which
org.eclipse.jdt.internal.core.CompilationUnit.buildStructure(OpenableElementInfo, IProgressMonitor, Map, IResource) takes (2437ms vs 0ms)



Reproducible: Always
Comment 1 Olivier Thomann CLA 2009-10-22 15:24:07 EDT 
Could you please give more details?
What is the jdt.core bundle's version in both builds?

Jay, could you please investigate once the requested information is provided?
Comment 2 Jay Arthanareeswaran CLA 2009-11-01 23:52:40 EST 
Created attachment 151043 [details]
Plugin patch

Since I see the problem to be in the same code area as the bug 293821, I suspect the fix could be same. Could you please try the attached plug-in patch?
Comment 3 Jay Arthanareeswaran CLA 2009-11-11 03:09:12 EST 
Kenneth, did you get a chance to try your performance tests with the plugin patch provided with comment #2? Please let me know the results.
Comment 4 Kenneth Cheung CLA 2009-11-27 14:20:42 EST 
Looks better now thanks.