Community
Participate
Working Groups
The preference for build.properties related problem is associated with many problem. Create a separate section for build.properties covering the preferences liked with each property like source.<library>, src.includes, etc.
I see about 8 different kinds of problems including the following. However, I'm not sure if it justifies a new section in the preferences. I can't see why someone would want to ignore any of them. This enhancement should probably wait until it is requested by the community. BuildErrorReporter_missingFolder=The folder "{0}" does not exist in the workspace BuildErrorReporter_sourceMissing=The plug-in's classpath library '.' does not have a corresponding source build entry BuildErrorReporter_cannotFindJar={0} cannot be resolved BuildErrorReporter_cannotFindBundle=Bundle {0} cannot be resolved Builders_Manifest_key_not_found = Key ''{0}'' is not found localization properties file Builders_Manifest_useless_file = A plug-in manifest must contain at least one extension or extension point BuildErrorReporter_missingEntry=An "{0}" build entry is missing Builders_Convert_missingAttribute = ''{0}'' attribute is missing Builders_Convert_illegalValue = Illegal value for ''{0}'' attribute BuildErrorReporter_emptyEntry=Build entries must contain at least one value BuildErrorReporter_missingFile=The file "{0}" does not exist in the workspace
(In reply to comment #1) > I see about 8 different kinds of problems including the following. However, > I'm not sure if it justifies a new section in the preferences. I can't see why > someone would want to ignore any of them. This enhancement should probably > wait until it is requested by the community. User may not want to ignore them. But they might want to mark some as Error and some less important ones like bug #154292 as warnings. But I agree we have more priority stuff to take care before this one.
Bug 291528 may be an exception here. It is synchronizing the compiler warnings and error settings. The build.properties here will affect the nightly and integration builds. Some developers may wish to have different settings for development in the workspace (more strict?) that what they have in the real builds. In this case they would want to turn off the warning when those particular properties are out of synch.
Created attachment 154704 [details] New build.properties related preferences let me know your comments
* I would suggest to name the top-level twisty "Build" instead of "build.properties". * In general, "with" should be used instead of "in" - for example: "problems with binary build entry" * Can we be more specific about the problems? For example instead of "Problems with Java compliance", say "Missing or incompatible Java compliance property". (Obviously, this is more difficult if the entry pertains to more than one possible problem).
Created attachment 155178 [details] Fix
Created attachment 155179 [details] junit This patch also needs projects zipped in next attachment
Created attachment 155180 [details] sample projects for testing This zip file contains zipped projects. They should be unzipped to the location org.eclipse.pde.ui.tests\tests\build.properties
I discovered the following issue: * Launch new target workspace * Create a new plug-in project a.b.c, with default settings * Open the build.properties * Remove the output.. entry * Open workspace preferences, change the severity for "Missing output.<library> entry" to "Warning". * build occurrs An error appears rather than a warning. Reverting the severity to ignore does not make the error go away. Even cleaining the project does not make the error go away.
Created attachment 155261 [details] patch updated patch. The severity settings were not properly initialized - as well, validation was bailing when the general setting was set to "ignore".
Darin, if you are OK with the JUnit too then I will go ahead and commit the patch?
Created attachment 155630 [details] Updated fix patch Sync'ed patch to HEAD Reequenced and reworded the prefs.
Created attachment 155751 [details] updated lables I updated the lables to make them consistent with respect to "entries" vs. "entry", and using property names with single quotes.
Ankur, the tests should validate the "buildEntry.key" value as well as the token value, as the key defines which property has the error. Would it be possible to add a test for the following (when I do this manually, I see an error)? * Create a new project that uses workspace severity settings * Delete the "output.." that is generated in build.properties * Set severity for missing "output.<library>" to "warning". > warning appears (as it should) * Set severity for missing "output.<library>" back to "ignore" > warning remains, but should go away
(In reply to comment #14) > Ankur, the tests should validate the "buildEntry.key" value as well as the token > value, as the key defines which property has the error. The tests sort of f does that only. The test will match the severity levels of all markers/entry combination (BaseValidator.verifyBuildPropertiesMarkers) after setting the governing preference (using BaseValidator.setPreferences).
Created attachment 156920 [details] Test Cases I am not able to check in o.e.pde.ui.tests
Created attachment 156922 [details] Test Projects The two zips inside this one shall go to tests folder in o.e.pde.ui.tests o.e.pde.ui.tests ¦ +---tests ¦ +---build.properties org.eclipse.pde.tests.build.properties.one.zip org.eclipse.pde.tests.build.properties.two.zip
I am not able to check in the test cases in o.e.ui.tests. Perhaps because I need to create new folder and check-in zips inside it. Curtis/Darin, can you do it for me. Or if am missing something, do let me know. thanks, Ankur..
Tests released. Marking fixed. Will open new bugs as required.
