Bug 291523 - For SPR-5307: adjust wild annotation patterns during resolve()
Summary: For SPR-5307: adjust wild annotation patterns during resolve()
Status: RESOLVED FIXED
Alias: None
Product: AspectJ
Classification: Tools
Component: Compiler (show other bugs)
Version: 1.6.6   Edit
Hardware: PC Windows NT
: P3 normal (vote)
Target Milestone: 1.6.7   Edit
Assignee: aspectj inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-06 14:33 EDT by Andrew Clement CLA
Modified: 2009-10-06 20:40 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Clement CLA 2009-10-06 14:33:41 EDT 

    


    


      



        
          Comment 1
        

        
          Andrew Clement CLA

        

        
        

        
          2009-10-06 14:34:43 EDT
        

      






See https://jira.springsource.org/browse/SPR-5307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=47131#action_47131

Due to the resolution strategy within Spring, the annotation type pattern is not resolved correctly.

    


    


      



        
          Comment 2
        

        
          Andrew Clement CLA

        

        
        

        
          2009-10-06 14:45:39 EDT
        

      






PointcutParser.parseTypePattern() is used by Spring and that is where resolution is kicked off.  There is no context there unfortunately (apart from the world) so we don't know where the type pattern came from - this makes it impossible to determine imports that would be respected for non-fully qualified names.

Right now resolve() for WildAnnotationTypePattern doesn't do anything where resolveBindings() does lots.  resolveBindings() is context aware.  We can do something in resolve() though if it looks like a fully qualified name.  We can see if it is a dotted name and then attempt world resolution for the name.  If that succeeds we can transform the internal type pattern into an ExactTypePattern.

    


    


      



        
          Comment 3
        

        
          Andrew Clement CLA

        

        
        

        
          2009-10-06 20:40:06 EDT
        

      






changes committed

    


    


      



        
          Comment 4
        

        
          Andrew Clement CLA

        

        
        

        
          2009-10-06 20:40:33 EDT
        

      






forgot to resolve fixed!