Community
Participate
Working Groups
Created attachment 148830 [details] Initial breakpoints VM implementation. Platform Debug bug 238956 will add support for the flexible hierarchy viewer in the breakpoints view. This will allow DSF and other debug models to supply model-specific content in the Debug view, and by extension allow DSF to implement proper support for "Link with Debug View" and "Show Debug Target Breakpoints" features of the Breakpoints view. I've implemented an initial (and incomplete) version of DSF breakpoints view support in the attached patch.
Created attachment 152542 [details] Updated patch. Update with work in progress. The only known issue is the fact that a working which is updated with a new breakpoint does not automatically expand. Plus there are other known issues with the flexible breakpoint view itself.
Created attachment 152881 [details] Updated patch. I only did functional testing of the obvious features, but it seems complete. Once the flex hierarchy breakpoint changes get into HEAD in platform, I'll clean up and commit it.
Pawel, What is the plan to include this patch into head? I would like to make use of this instead of rewriting my own for helio. Patrick
(In reply to comment #3) > Pawel, > > What is the plan to include this patch into head? I would like to make use of > this instead of rewriting my own for helio. > > Patrick I was going to wait till after M5 since we would break the CDT build if we committed it sooner than that. I haven't looked at this patch in a while though and I remember that the patch still needed some work which I discovered during completing the platform work. Have you come accross any issues?
(In reply to comment #4) > Have you come accross any issues? I have been playing with this patch for a day, and I haven't find any major issue yet. It is in pretty good shape. I will continue to do more testing and will report back if I find any major issue. I haven't test tracking/filter/editing feature yet, only tested the basic display and column support so far. The patch required updating the references for class relocation in the platform, which I have done locally.
(In reply to comment #4) > Have you come accross any issues? - The current patch doesn't seem to do any filtering based on the active debug context. I don't see any where in the code to call back into the backend to filter breakpoint like the platform does with IDebugTarget.supportsBreakpoint(). Perhaps I am missing something here. - Track selection is not implemented yet. - Inserting breakpoint does not expand the parent nodes.
Adding to the list of issue... The properties dialog context menu action in the breakpoint view is missing.
(In reply to comment #4) > I was going to wait till after M5 since we would break the CDT build if we > committed it sooner than that. M5 is out, do you have a time frame when this patch can be committed? I can give you a hand to polish this patch. > I haven't looked at this patch in a while > though and I remember that the patch still needed some work which I discovered > during completing the platform work. The latest patch needs to at least have the references updated due to changes in the platform. I have a local copy of this patch with the references updated. If you like, I can attach the patch.
(In reply to comment #8) > The latest patch needs to at least have the references updated due to changes > in the platform. I have a local copy of this patch with the references updated. > If you like, I can attach the patch. Yes, that would be very helpful. I'm actually busy at the moment with other fallout from the breakpoints view change. I regret that I didn't take not of what else I thought needs to be done in this patch. It had something to do with dealing with multiple model proxies registering with the VM... In any case it's better to check in the patch as is and refactor it later as needed rather than leave it sitting in this bug.
Created attachment 158630 [details] Patch with reference updated (incremental changes over previous patch)
I committed the fix and I'll open bugs for the remaining issues. I'm not sure who has time to review this bug, but a review will be helpful. Patrick (TI) is already using the patch so I assume he will raise additional issues as they come up. Also, this bug contains a breaking change in the provisional View Model API (see IVMModelProxy.getEventDeltaFlags()).
