Community
Participate
Working Groups
Created attachment 148827 [details] Patch with proposed fix. The stale data color indicates that the data in the view is no longer accurate, and that the view needs to be refreshed. The problem is that this color sometimes shows up in the variables views when stepping fast even when the view is in the automatic update mode. This degrades performance as the UI repaints the view needlessly. The reason for the flickering is that the DSF View Model (VM) optimizes out view updates when the events are arriving faster than the VM can process them. This is implemented by not flushing the cache, however the view may still be periodically repainted. When the cache data is not flushed and a target event indicates that it should be, the cache data is marked as stale. If the view happens to be repainted in that time, then the view will show data as stale. The fix that I implemented simply disables the stale data marking when in automatic update mode. I don't think it should have any bad side effects.
I committed the fix. Toni please review.
There is one problem with this patch: When I switch to manual mode and perform a step, the color does not change to gray. I have to refresh once, then the next step changes to gray again. The reason seems to be that the update policy id is also cached with the other properties and subsequent updates occur with the wrong update policy id.
Created attachment 148904 [details] Patch with additional fix. (In reply to comment #2) Oops! This patch adds logic to update this property on cache hits too.
Committed the additional fix. Toni, please take a look again.
Forgot to mark fixed.
Looks good now.
