Community
Participate
Working Groups
Hi there, I noticed that the manifest of the JDT Core Batch Compiler (ecj-3.6.M2.jar) is not up-to-date: http://download.eclipse.org/eclipse/downloads/drops/S-3.6M2-200909170100/index.php#JDTCORE The Manifest states that the Bundle-Version is 3.3.0 This also affect 3.5.* Also it would be nice to update the entries of the MANIFEST.MF of ecj-sources.zip so that its Bundle-Version is also up-to-date and so that it is recognized by the PDE as the sources bundle of the ecj. I think this extra entry would do that: Eclipse-SourceBundle: org.eclipse.jdt.core.compiler.batch;version="3.6.M2";roots:="." Thanks!
This is the manifest used for the ecj jar file available on the Eclipse download site.
Released for 3.6M3. I'll check next N-build to make sure the jar and zip files look ok.
N-build ecj.....jar and source bundles look good. We might want to apply the same patch for 3.5.2 (with version updated to 3.5.2 instead of 3.6.0).
Created attachment 149245 [details] Proposed fix for 3.5 maintenance
Created attachment 149247 [details] Proposed fix for 3.5 maintenance Small changes.
In fact to define a source bundle I should really convert the zip file to be a jar file. I'll talk with Kim about this. With the current patch, the source zip can be renamed to a jar to be a source bundle.
Thanks Olivier and thanks for fixing the sources bundle too: This morning I wondered why equinox was not picking up the batch compiler in my setup... it was picking up the sources instead. Also I suspect that it might mislead OSGi to keep the runtime entries in the sources bundle: equinox will think that the sources jar is exporting those packages.
You are right. I should clean up some entries in the MANIFEST.MF file from the source zip. Released in HEAD. Kim only need to update some links in the download page if we move to a jar file for the source bundle. So this would be easy to do. Right now a manual rename is required. I'll update the patch for 3.5 maintenance accordingly.
Created attachment 149248 [details] Proposed fix for 3.5 maintenance Updated patch to remove entries in the source MANIFEST.MF
Created attachment 149267 [details] Proposed fix for 3.5 maintenance Adding package export of internal packages coming from compiler.apt and compiler.tool fragments.
Not critical enough to backport.
Verified for 3.6M3 using build I20091025-2000.
