Community
Participate
Working Groups
Review the usability of the New Server Wizard. From a usability point of view currently we are doing dual filtering on the server type table, perhaps we should fine a better way of doing the filter and server type selection. The first filter is based on the hostname, when a user enter a hostname we filter show only server types that support remote connections. The second filter could be based on a server type name or vendor name, when a user enters text inside of the filter box right above the table.
Instead of doing dual filter, the new server wizard flow should allow the user to select the server type first and then the host name. Users normally care more about a particular server type the location of the server when publishing applications. Switching the server type selection and the host name selection will address the existing dual filtering problem.
Created attachment 152778 [details] Creates the host name controls before server name control instead of first input from user Currently, the New Wizard first page drives it createControl() method from the NewServerComposite. It is from there that the server host name composite is laid out. I propose, that we change the order of the flow such that the first selection or input from user is to pick a server type. Only after this selection should he be queried for a server host name. Since a call is made out to create the hostname composite from the NewServerWizard composite to a NewManualServerWizard (the changes should be isolated to creating a new server only) which creates the server selection control followed by the server name field, to change the flow I am proposing the followig: 1. The call to create the host name control from NewServerWizard which creates it as the first text field be removed; 2. Instead, the host name is created from the NewManualServerComposite just after laying out the server selection control but before the server name control, ie, inserting it between those controls such that the flow makes more sense.
(In reply to comment #2) Thanks for the patch. I have tested your changes and they worked, although I don't understand why you have to create a new field instead of using the HostnameComposite that already contains the field with its FieldDecoration. Maybe because of layout problems? I accept the changes with a few modifications, if we have time we would probably want to revisit this code and clean it up a bit more. I will drop the changes tonight so that we can start testing.
Created attachment 153120 [details] New Server Wizard - Original layout
Created attachment 153121 [details] New Server Wizard - New layout
Created attachment 153173 [details] New extension point for adding content to first page Attached is a suggested new extension point that would allow adopters a way to insert user-defined controls/content at the point in the server wizard page 1 just after the server selector control but before the host name control. This allows the main look and feel and philosophy behind the server wizard first page to remain as it is, but still give adopters flexibiltiy to add specific content for the tasks to be done for their particular use-cases. A new extension point is defined in the server.ui for page section additions.
Created attachment 153190 [details] New extension point for adding content to first page v2 patch This patch replacess New_Page_Extension_Point_Patch.txt because there was one more method I meant to add in order to disable the user-defined control based on a given server selection. This is because this extension point is meant to function - be available, undisabled, only if the server type is supported for the given controls. Please ignore then the last patch and I marked the other as obsolete.
Created attachment 153379 [details] Supports the new flow of the new server wizard flow With the improved task flow in the New server wizard by placing the host name entry field after the server type selection, rather than before it, as the first part of the task, it leaves current implementation of the serverType content provider with some old behaviour no longer appropriate. Specifically, in the case where the host name contents are changed away from "localhost" or its equivalent, "127.0.0.1", those server types deemed to not support remote host are FILTERED OUT in the UI ABOVE it. This further patch on the ease of use improves on that behaviour by instead of filtering out server types in the content provider/tree viewer, not supported by remote hosts, it instead will do two things: 1. put up a message that: "The selected server type is not supported for remote hosts" 2. It prevents Next/Finsh by disabling. Should a user keep the non-local host name but then select a different server type that does support remote hosts, the buttons will be enabled and the message nulled out. That is, a combination of handling on the server type selection as well as changes to the host name text, ensures that if a server type is not supported for remote hosts AND the hostname is not local, the Next and Finish are tdisabled, only cancel is avaliable and the error message is set. Changing the host name back to "localhost" (ignore case) or 127.0.0.1 will clear the message and permit the next and/or finish buttons. Similarly, selecting a server type that does support remote hosts will have the same result. It is thought that this patch should now fully satisfy the requirements for this bug.
Created attachment 153384 [details] Shows the new behaviour for non-remote hosts/server types
Created attachment 153385 [details] Shows the new behaviour for non-remote hosts/server types, when not supporteds
Sheldon, Thank you for the patch, but I had problems trying to apply it, perhaps is because I recently committed some changes for another bug. I try fix the patch manually, and then tested. But after your changes I didn't see any change in behaviour as per the screenshots you attached. I wonder if there is changes that are missing or if I by mistake (on the manual merge of your patch and the HEAD code) remove something important. Is it possible to review your patch and re-submit it? A couple of comments while you are looking at the code, ensure that you update the copyrights and that you follow the formatting of the code.
Created attachment 153605 [details] Created new patch off fresh head Angel, I have attached a patch off head after you made all your updates because you had problems applying it after previous patches. Again, the point of this fix is to prevent the wizard finishing when a combination of a server type that does not support remote hosts is selected at the time non-localhost host name or IP address that is not 127.0.0.1 is entered for the server host name. For such a case an error message that "The currently selected server type does not support remote hosts" will be set and the Next and or Finish button(s) disabled. Upon either re-selecting a different server type that does support remote hosts or the host name is changed (back) to localhost/127.0.0.1, the error message shall be cleared and further progress through the wizard permitted. The affected files in patch are illustrated in attached .png file.
Created attachment 153607 [details] patched files affected
Comment on attachment 153605 [details] Created new patch off fresh head For the most part the changes are okay. I did do a couple of modifications and updated the copyrights and formatting of the code. I will attach my patches in case you want to compare
Created attachment 153621 [details] v1.2 - Part 2 of the changes for filtering improvements
Changes committed to HEAD
Changes released to HEAD
changes completed.
New Gerrit change created: https://git.eclipse.org/r/108830
New Gerrit change created: https://git.eclipse.org/r/108836
