Bug 291019 - Wrong usage of log level configuration because of StdErrLog
Summary: Wrong usage of log level configuration because of StdErrLog
Status: RESOLVED FIXED
Alias: None
Product: Jetty
Classification: RT
Component: build (show other bugs)
Version: 7.0.0   Edit
Hardware: PC Windows Server 2003
: P3 normal (vote)
Target Milestone: 7.0.1 M1   Edit
Assignee: Athena Yao CLA
QA Contact:
URL:
Whiteboard:
Keywords: core
Depends on:
Blocks:
 
Reported: 2009-10-01 07:00 EDT by MichZem CLA
Modified: 2009-10-08 02:56 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description MichZem CLA 2009-10-01 07:00:49 EDT 
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US) AppleWebKit/532.0 (KHTML, like Gecko) Chrome/4.0.203.2 Safari/532.0
Build Identifier: 

When we want to increase the log level of jetty (as standalone, for ex), we should use the -D/myWebApps.DEBUG=true or simply -DDEBUG=true
But the code, in StdErrLog (org.eclipse.jetty.util.log.StdErrLog.StdErrLog(String name)) is wrong:

Instead of looking for -D.DEBUG=true, it looks for -Dnull.DEBUG=true

The right code should be:
        this._name=name==null?"":name;
        _debug=Boolean.parseBoolean(System.getProperty(this._name+".DEBUG",Boolean.toString(__debug)));


Reproducible: Always

Steps to Reproduce:
1.Run jetty, by using java -D.DEBUG=true org.eclipse.jetty.start.Main
2.Jetty wont be verbosed: it still uses INFO as default level
3.Instead, use java -Dnull.DEBUG=true org.eclipse.jetty.start.Main and only then, jetty will be verbose.
Comment 1 MichZem CLA 2009-10-01 07:02:42 EDT 
The wrong code was seen in jetty 7.0.0 RC 6
I didnt look backward in the history
Comment 2 Athena Yao CLA 2009-10-08 02:56:12 EDT 
r982 -- picked this up to get it out of the way. Thanks for the report, MichZem.