Bug 290317 - AgentLocation API cleanup
Summary: AgentLocation API cleanup
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.6 M4   Edit
Assignee: John Arthorne CLA
QA Contact:
URL:
Whiteboard:
Keywords: api
Depends on:
Blocks:
 
Reported: 2009-09-23 15:41 EDT by John Arthorne CLA
Modified: 2009-11-09 13:30 EST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description John Arthorne CLA 2009-09-23 15:41:23 EDT
Before graduating AgentLocation as real API it needs some cleanup:

 - It currently uses a mixture of URL and URI. It should probably just use URI.
 - Rename getURL() to something informative like getRootLocation() or getAgentRoot()
 - getMetadataRepositoryURI should be removed - this represents the metadata cache which we no longer have
 - getArtifactRepositoryURI returns the download cache. Since this method just forwards to getDataArea(String) with a value of "cache/", it could probably just be deleted and make the string constant available somewhere. I'm not sure we want to support the notion of a single artifact cache at the core level, so perhaps this constant should live elsewhere, such as the artifact repository API.
Comment 1 John Arthorne CLA 2009-11-09 13:30:27 EST
Fix released in p2 API_cleanup branch.