Bug 290209 - Photran is lacking C-preprocessor support
Summary: Photran is lacking C-preprocessor support
Status: RESOLVED FIXED
Alias: None
Product: PTP
Classification: Tools
Component: Photran.For Internal Use (show other bugs)
Version: 4.0   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: 6.0   Edit
Assignee: Jeffrey Overbey CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 286446
Blocks: 304430 309043 305576 309045
  Show dependency tree
 
Reported: 2009-09-23 00:38 EDT by Matthew Michelotti CLA
Modified: 2011-01-31 08:05 EST (History)
3 users (show)

See Also:


Attachments
contains two projects which assist with c-preprocessor support (323.31 KB, application/zip)
2009-09-23 00:38 EDT, Matthew Michelotti CLA
g.watson: iplog+
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Matthew Michelotti CLA 2009-09-23 00:38:40 EDT
Created attachment 147851 [details]
contains two projects which assist with c-preprocessor support

Photran is currently lacking C-preprocessor support. I have been working on
code with Jeff Overbey for a while to provide such support, and what is done so
far is attached to this bug report.
Comment 1 Jeffrey Overbey CLA 2009-09-23 12:50:57 EDT
Matthew,

Can you please confirm that

1. you wrote 100% of the code without incorporating content from elsewhere or
relying on the intellectual property of others,

2. you have the right to contribute the code to Eclipse, and

3. you have included the EPL license header in all source files?

(This is for the IP review.  For #1, since you borrowed code from Photran and CDT, you'll just need to state that explicitly.)

Thanks.
Jeff
Comment 2 Matthew Michelotti CLA 2009-09-23 17:53:04 EDT
(In reply to comment #1)
> Matthew,
> 
> Can you please confirm that
> 
> 1. you wrote 100% of the code without incorporating content from elsewhere or
> relying on the intellectual property of others,
> 
> 2. you have the right to contribute the code to Eclipse, and
> 
> 3. you have included the EPL license header in all source files?
> 
> (This is for the IP review.  For #1, since you borrowed code from Photran and
> CDT, you'll just need to state that explicitly.)
> 
> Thanks.
> Jeff

1. I have written all of the code except for code taken from CDT and altered, and some code from Photran. Regardless, all of the copyright notices at the top of source files are correct. Altered versions of CDT files retain their original copyright notices.

2. I have the right to contribute this code to Eclipse.

3. I have included the EPL license header in all source files
Comment 3 Jeffrey Overbey CLA 2009-10-02 09:54:44 EDT
CQ requested
Comment 4 Jeffrey Overbey CLA 2009-11-11 16:58:14 EST
http://dev.eclipse.org/ipzilla/show_bug.cgi?id=3566

The CQ was approved, subject to two changes:

(1) The Contributor's name should be included in the
Contributor Section of the file headers rather than
further down in the file.  This can be adjusted prior
to checkin unless something else needs to be amended.

(2) The following files contain the word "confidential"
in the file name or in the content.  We should rename
these.  The word should really be "optional," not
"confidential."
a.  PrintProjectConfidentialFMLIB.java
b.  PrintProjectConfidentialArjanVanDijkAtmos.java
c.  AbstractCppTestSuite.java (contains confidential in a comment)
d.  PrintProjectConfidentialAsteroids.java
e.  PrintProjectConfidentialPOP.java
Comment 5 Jeffrey Overbey CLA 2010-02-25 00:09:23 EST
Tim, can you please take care of #1 in Comment 4?  I.e., for every file that Matthew changed, add UIUC to the list of contributors in the copyright header at the very top of the file?

When that's done, please assign this bug back to me, and I'll take care of #2 and move the preprocessor into public CVS.
Comment 6 Timofey Yuvashev CLA 2010-02-25 15:24:55 EST
(In reply to comment #5)
> Tim, can you please take care of #1 in Comment 4?  I.e., for every file that
> Matthew changed, add UIUC to the list of contributors in the copyright header
> at the very top of the file?
> 
> When that's done, please assign this bug back to me, and I'll take care of #2
> and move the preprocessor into public CVS.

It's done. I committed it.
Comment 7 Jeffrey Overbey CLA 2010-02-25 15:37:23 EST
#2 is done as well.  The code should be ready for check-in to CVS.
Comment 8 Jeffrey Overbey CLA 2010-03-02 17:20:33 EST
Committed to CVS