Bug 289273 - Support editing location of Valgrind binary
Summary: Support editing location of Valgrind binary
Status: RESOLVED FIXED
Alias: None
Product: Linux Tools
Classification: Tools
Component: Valgrind (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 0.4   Edit
Assignee: Roland Grunberg CLA
QA Contact:
URL:
Whiteboard:
Keywords: noteworthy
Depends on:
Blocks:
 
Reported: 2009-09-11 22:09 EDT by Elliott Baron CLA
Modified: 2009-11-05 08:59 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Elliott Baron CLA 2009-09-11 22:09:56 EDT 
Probably best to introduce a simple preference preference page for this.
Comment 1 Roland Grunberg CLA 2009-11-02 14:54:55 EST 
Added a preference page for valgrind along with a textbox to provide location of binary (either manually or by browsing file system). The preference page binary path overrides what `which valgrind` finds.

#23584
Comment 2 Andrew Overholt CLA 2009-11-03 08:27:35 EST 
Feel free to close this, Roland.  I assume you've verified that your patch showed up in our nightly build?  Thanks.
Comment 3 Roland Grunberg CLA 2009-11-03 09:27:41 EST 
Patch shows up on automated builds.
Comment 4 Elliott Baron CLA 2009-11-04 11:07:38 EST 
Nicely done Roland, thanks!
Comment 5 Andrew Overholt CLA 2009-11-04 11:11:20 EST 
Elliott, do you think this is N&N-worthy?
Comment 6 Elliott Baron CLA 2009-11-04 16:15:45 EST 
Definitely. I'll update the N&N section for 0.4.
Comment 7 Andrew Overholt CLA 2009-11-05 08:59:01 EST 
Thanks Elliott.