Bug 288780 - [open type] Improve FilteredTypesSelectionDialog to better work with hierarchy scopes
Summary: [open type] Improve FilteredTypesSelectionDialog to better work with hierarch...
Status: CLOSED WONTFIX
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.5   Edit
Hardware: PC Linux
: P3 enhancement (vote)
Target Milestone: 3.6 M5   Edit
Assignee: Markus Keller CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 215139
Blocks:
  Show dependency tree
 
Reported: 2009-09-07 18:34 EDT by Stephan Herrmann CLA
Modified: 2009-10-05 14:18 EDT (History)
1 user (show)

See Also:


Attachments
proposed patch (1.61 KB, patch)
2009-09-07 18:39 EDT, Stephan Herrmann CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stephan Herrmann CLA 2009-09-07 18:34:16 EDT
User-Agent:       Mozilla/5.0 (compatible; Konqueror/4.2) KHTML/4.2.2 (like Gecko)
Build Identifier: 3.5

Bug 215139 tries to bring more options to hierarchy scopes in order
to support searching for subtypes of a given type only.

This was requested in the context of bug 61185 in order to provide
a type selection dialog for subtypes of a given type.

One proposed solution (bug 215139 comment 35 f.) requires that
in addition to changes to the hierarchy scope, also clients would
have to pass a slightly different requestor.

Thus I'm opening this bug to ask if this little change can be
adapted into the JDT/UI (patch to be uploaded in a second).


Reproducible: Always

Steps to Reproduce:
Background is discussed in bug 215139, but if needed, I can of course
explain why specifically this change would help.



Note that bug 61185 (opened more than 5 years ago ;-) currently has
a half-cooked solution.

Bug 215139 which tries to provide that help to fully resolve
bug 61185 is dragging for some time now. It seems with the help of
the little patch to JDT/UI, we could actually make some progress.
Comment 1 Stephan Herrmann CLA 2009-09-07 18:36:44 EDT
Yeah, with the new bigzilla forms we have to live with all this noise:

Build Identifier: 3.5
Reproducible: Always
Steps to Reproduce:

no way I could delete those :-/
Comment 2 Stephan Herrmann CLA 2009-09-07 18:39:15 EDT
Created attachment 146626 [details]
proposed patch

And here's the patch. Actually the same as I attached to
bug 215139 comment 37
Comment 3 Markus Keller CLA 2009-09-08 13:38:29 EDT
The patch looks good and I have no problem committing this if bug 215139 does not resolve the problem in 3.6.

However, bug 215139 is still real, and I'd prefer the inconsistencies to be fixed in the jdt.core API.

When releasing this, also explain the hack in the code and link to this bug.
Comment 4 Stephan Herrmann CLA 2009-10-05 14:18:22 EDT
No longer needed since bug 215139 is going for the core-only solution.